gtg team mailing list archive

[Bertrand Rousseau <bertrand.rousseau@xxxxxxxxx>]

** Changed in: gtg
   Importance: Undecided => Low

** Changed in: gtg
       Status: New => Fix Committed

** Changed in: gtg
    Milestone: None => 0.2

** Changed in: gtg
     Assignee: (unassigned) => Luca Invernizzi (invernizzi)

-- 
redefinition of function get_closed_date in task.py
https://bugs.launchpad.net/bugs/428145
You received this bug notification because you are a member of Gtg
developers, which is the registrant for Getting Things GNOME!.

Status in Getting Things GNOME!: Fix Committed

Bug description:
In latest trunk (revision 299.1.12):
$pyflakes GTG/core/task.py
task.py:225: redefinition of function 'get_closed_date' from line 84

That is because:
task.py, line 84:

    def get_closed_date(self):
        return self.closed_date

was added by  bertrand (246.1.10) , while

task.py, line 225:
    def get_closed_date(self): 
        if self.closed_date: 
            return str(self.closed_date) 
        else: 
            return ''"
was added by bertrand (302) and  ploum (40.1.21, 117.1.1)

The second one is more conservative, so here's the patch to remove the first one.