gtg team mailing list archive

[Bryce Harrington <bryce@xxxxxxxxxxxxxxxxxxx>]

On Mon, Mar 01, 2010 at 09:24:55AM -0000, Luca Invernizzi wrote:
> I've not been involved in the refactoring so I'll just drop my thoughts:
> 
> That certainly fixes it, but I have two questions:
>  - I remember Lionel saying "always pass ids as arguments, never objects except when needed". Shouldn't the tid be passed instead?

Yeah, but making the fix this way was a bit too advanced for me.

>  - the add_parent declaration in task.py has a comment "Take a tid
object as parameter", but it really wants a task object.

I think this is the real bug here.  My "fix" just works around this
problem, but maybe helps confirm this as the issue.

Bryce

-- 
[gtg-refactor] Failure adding subtask
https://bugs.launchpad.net/bugs/529746
You received this bug notification because you are a member of Gtg
contributors, which is subscribed to Getting Things GNOME!.

Status in Getting Things GNOME!: Confirmed

Bug description:
This is a regression on the gtg-refactor branch.
Steps to reproduce:

1. Launch gtg via ./scripts/debug.sh
2. Select 'Getting started with GTG'
3. Create a new subtask (Ctrl+Shift+N)

A new task is added visible from the taskbrowser, but it's not set as a subtask.

This error is printed:

Traceback (most recent call last):
  File "/home/bryce/src/gtg/gtg-refactor/GTG/taskbrowser/browser.py", line 1203, in on_add_subtask
    task.add_parent(uid)
  File "/home/bryce/src/gtg/gtg-refactor/GTG/core/task.py", line 392, in add_parent
    added = TreeNode.add_parent(self,parent)
  File "/home/bryce/src/gtg/gtg-refactor/GTG/core/tree.py", line 281, in add_parent
    id = par.get_id()
AttributeError: 'str' object has no attribute 'get_id'