gtg team mailing list archive

[Lionel Dricot <ploum@xxxxxxxxx>]

This is a very interesting usecase. Your fix is good but, if we want to
be really perfect, we should do it otherwise.

In fact, the TaskEditor should catch the "task-deleted" signal from the
requster and react by closing itself.

This has several advantages : TaskEditor is independant from the
ViewManager and can be replaced by any TaskEditor module while, with
your fix, we create a strong dependancy that the TaskEditor should
always have a destroy function that does what it's expected it should be
doing (and this is not always clear).

By reaction to the signal, you are taking your own responsibility, just
like the browser is doing right now.

This is, in essence, the new philosophy I had when doing the
refactoring. (I hope it will work but, to be honnest, I don't believe
that connecting to the signal is harder than your fix)

-- 
deleting a task from the task editor does not close it
https://bugs.launchpad.net/bugs/529919
You received this bug notification because you are a member of Gtg
contributors, which is subscribed to Getting Things GNOME!.

Status in Getting Things GNOME!: Fix Committed

Bug description:
Deleting a task from the taskeditor does delete the task but doesn't close the editor itself.