gtg team mailing list archive

[Luca Invernizzi <invernizzi.l@xxxxxxxxx>]

I'll have a look. 
On Mon, Mar 01, 2010 at 10:31:47AM -0000, Lionel Dricot wrote:
> I'm reading your commit (but I didn't tested). I'm a bit annoyed because
> now it means that Task and TreeNode have different specifications for
> the add_parent method, which is bad because Task extends TreeNode.
> 
> I think that add_parent should be also fixed in TreeNode and thus
> everywhere it is used.
> 
> -- 
> [gtg-refactor] Failure adding subtask
> https://bugs.launchpad.net/bugs/529746
> You received this bug notification because you are a bug assignee.
> 
> Status in Getting Things GNOME!: Fix Committed
> 
> Bug description:
> This is a regression on the gtg-refactor branch.
> Steps to reproduce:
> 
> 1. Launch gtg via ./scripts/debug.sh
> 2. Select 'Getting started with GTG'
> 3. Create a new subtask (Ctrl+Shift+N)
> 
> A new task is added visible from the taskbrowser, but it's not set as a subtask.
> 
> This error is printed:
> 
> Traceback (most recent call last):
>   File "/home/bryce/src/gtg/gtg-refactor/GTG/taskbrowser/browser.py", line 1203, in on_add_subtask
>     task.add_parent(uid)
>   File "/home/bryce/src/gtg/gtg-refactor/GTG/core/task.py", line 392, in add_parent
>     added = TreeNode.add_parent(self,parent)
>   File "/home/bryce/src/gtg/gtg-refactor/GTG/core/tree.py", line 281, in add_parent
>     id = par.get_id()
> AttributeError: 'str' object has no attribute 'get_id'
> 
>

-- 
[gtg-refactor] Failure adding subtask
https://bugs.launchpad.net/bugs/529746
You received this bug notification because you are a member of Gtg
contributors, which is subscribed to Getting Things GNOME!.

Status in Getting Things GNOME!: Fix Committed

Bug description:
This is a regression on the gtg-refactor branch.
Steps to reproduce:

1. Launch gtg via ./scripts/debug.sh
2. Select 'Getting started with GTG'
3. Create a new subtask (Ctrl+Shift+N)

A new task is added visible from the taskbrowser, but it's not set as a subtask.

This error is printed:

Traceback (most recent call last):
  File "/home/bryce/src/gtg/gtg-refactor/GTG/taskbrowser/browser.py", line 1203, in on_add_subtask
    task.add_parent(uid)
  File "/home/bryce/src/gtg/gtg-refactor/GTG/core/task.py", line 392, in add_parent
    added = TreeNode.add_parent(self,parent)
  File "/home/bryce/src/gtg/gtg-refactor/GTG/core/tree.py", line 281, in add_parent
    id = par.get_id()
AttributeError: 'str' object has no attribute 'get_id'