gtg team mailing list archive

[Luca Invernizzi <invernizzi.l@xxxxxxxxx>]

Possible implementation: 
we have a SignalsManager. When you need to intercept a signal you register yourself to the SignalManager. That way, it can keep track of who needs what.

When you receive your signal (either directly or via the signal manager, I think the second one is cleaner), once you've done your business, you tell the SM that you're done. He is a smart guy and can count, therefore  he can remove old elements and there no need for garbage collectors.
Am I missing something?

-- 
sometimes task is removed before task-deleted signal handler is executed
https://bugs.launchpad.net/bugs/582620
You received this bug notification because you are a member of Gtg
contributors, which is subscribed to Getting Things GNOME!.

Status in Getting Things GNOME!: Confirmed

Bug description:
Signals are executed when "there is time for them", without specific limits.

Now, when we issue the signal task-deleted, we should do a series of things (updating tags in the tag pane, removing the task and its children from the main view...).
A number of times we need to access information about the task that has been removed. Example: we need to check if the tag that we are updating in the tags pane should be shown or not (are there still tasks tagged with that?)

This causes a series of problems, among which the drag and drop "phantom tasks" (tasks that are shown twice), or crashes upon deletion of tasks because the signal arrived too late and we cannot get the list of tags that need to be updated.

How to solve this?instead of passing the tid along with the signal, I think we should pass a copy of the whole task.
I understand there are a series of things that need to be well thought out also with this approach and, since it's late and tomorrow is GTG Regression day, i'll regress to bed.