gtg team mailing list archive

[Bryce Harrington <bryce@xxxxxxxxxxxxxxxxxxx>]

I've attached a branch with a change to the filter code that seems to
fix it (at least for the test case in the description).

It seems that in __is_displayed(), if there is a tag filter using a tag
that is not defined, it skips processing of it (which is correct) but
the logic falls through to returning a True result by default.  This
branch changes this particular error case to default as False.


** Changed in: gtg
   Importance: Undecided => Medium

** Changed in: gtg
     Assignee: (unassigned) => Bryce Harrington (bryceharrington)

** Changed in: gtg
       Status: New => In Progress

** Changed in: gtg
    Milestone: None => 0.3

** Tags added: dailyuse

-- 
filtering on non-existant tags returns all tasks
https://bugs.launchpad.net/bugs/602108
You received this bug notification because you are a member of Gtg
contributors, which is subscribed to Getting Things GNOME!.

Status in Getting Things GNOME!: In Progress

Bug description:
Steps to reproduce:

0.  Startup gtg
1.  ./gtcli postpone @NonexistantTag 2011-07-05

This should be a no-op.  The tag doesn't exist, so when gtcli calls timi.get_tasks_filtered(filters) via DBUS, no tasks should be returned.  Instead, it ignores the filter and returns all tasks as if that tag had not been specified as a filter.