← Back to team overview

gtg team mailing list archive

Re: [Merge] lp:~gtg/gtg/viewcount into lp:gtg

 

Btw, it doesn't crash on my computer, but leave the following trace 
(after dropping "money" on "errands"):

Traceback (most recent call last):
  File 
"/home/rousseau/workspace/personal/gtg/viewcount/GTG/gtk/browser/browser.py", 
line 1152, in on_select_tag
    self.apply_filter_on_panes(tagname)
  File 
"/home/rousseau/workspace/personal/gtg/viewcount/GTG/gtk/browser/browser.py", 
line 1122, in apply_filter_on_panes
    vtree.apply_filter(filter_name, refresh=refresh)
  File "../liblarch/liblarch/viewtree.py", line 276, in apply_filter
    self.__ft.apply_filter(filter_name, parameters, reset, refresh)
  File "../liblarch/liblarch/filteredtree.py", line 635, in apply_filter
    self.refilter()
  File "../liblarch/liblarch/filteredtree.py", line 313, in refilter
    self.send_remove_tree(node_id, self.root_id)
  File "../liblarch/liblarch/filteredtree.py", line 287, in 
send_remove_tree
    self.callback('deleted', node_id, path)
  File "../liblarch/liblarch/filteredtree.py", line 124, in callback
    func(node_id,path)
  File "../liblarch/liblarch/viewtree.py", line 115, in __emit
    func(node_id,path)
  File 
"/home/rousseau/workspace/personal/gtg/viewcount/GTG/gtk/browser/treeview_factory.py", 
line 346, in _update_tags
    tree.refresh_node(t.get_name())
  File "../liblarch/liblarch/__init__.py", line 87, in refresh_node
    self.__tree.modify_node(node_id, priority)
  File "../liblarch/liblarch/tree.py", line 88, in modify_node
    self._queue.push(self._modify_node, node_id, priority=priority)
  File "../liblarch/liblarch/processqueue.py", line 65, in push
    func(*element[1:])
  File "../liblarch/liblarch/tree.py", line 269, in _modify_node
    self._callback('node-modified', node_id)
  File "../liblarch/liblarch/tree.py", line 78, in _callback
    func(node_id)
  File "../liblarch/liblarch/filteredtree.py", line 129, in 
__external_modify
    return self.__update_node(node_id,direction="both")
  File "../liblarch/liblarch/filteredtree.py", line 219, in 
__update_node
    for path in self.get_paths_for_node(node_id):
  File "../liblarch/liblarch/filteredtree.py", line 440, in 
get_paths_for_node
    raise Exception("%s is not children of %s\n%s" % (node_id, 
parent_id, s))
Exception: @money is not children of @errands

On Wed 31 Oct 2012 02:35:27 PM CET, Bertrand Rousseau wrote:
>
>
> On Mon 29 Oct 2012 03:34:31 PM CET, Lionel Dricot wrote:
>> Le 29/10/2012 15:29, Bertrand Rousseau a écrit :
>>> Then we should either disable tag DnD or solve it, but we can't let it
>>> crash GTG for such a common feature.
>>
>> It crashes only in that very specific configuration. I've been unable to
>> reproduce this bug in any other circumstances. I'm really wondering what
>> this bug is.
>
> The (very) annoying thing is that those default tasks invite the new
> user to try and test tag DnD. What is your estimation of the required
> work to fix this bug?
>
>>>
>>> I'd like to release GTG 0.3 asap, so let's disable it if it require
>>> advanced fix/testing. I'll let you judge about that.
>>
>> We cannot disable tag drag-n-drop, that's a major feature.
>>
>>>
>>> Bertrand
>>>
>>> On Mon 29 Oct 2012 03:13:25 PM CET, Lionel Dricot wrote:
>>>> No reported.
>>>>
>>>> 1. Launch GTG with default tasks
>>>> 2. Display sidebar (F9)
>>>> 3. Drag a tag and drop it on another
>>>>
>>>> That's all.
>>> --
>>> Bertrand Rousseau
>>> bertrand.rousseau@xxxxxxxxx
>>>
>>
>>
>
> --
> Bertrand Rousseau
> bertrand.rousseau@xxxxxxxxx

--
Bertrand Rousseau
bertrand.rousseau@xxxxxxxxx

-- 
https://code.launchpad.net/~gtg/gtg/viewcount/+merge/130696
Your team Gtg developers is subscribed to branch lp:~gtg/gtg/viewcount.


Follow ups

References