gtg team mailing list archive

[Chenxiong Qi <qcxhome@xxxxxxxxx>]

Chenxiong Qi has proposed merging lp:~qcxhome/gtg/bugfix-1218708 into lp:gtg.

Requested reviews:
  Gtg developers (gtg)
Related bugs:
  Bug #1218708 in Getting Things GNOME!: "Cannot open a task after that task is marked as not to be done anymore from Closed Tasks Pane"
  https://bugs.launchpad.net/gtg/+bug/1218708

For more details, see:
https://code.launchpad.net/~qcxhome/gtg/bugfix-1218708/+merge/183075

This patch fixes one critical problem that is one task can be opened only once and the subsequent open operations crash GTG. Also fix the bug linked to this patch.
-- 
https://code.launchpad.net/~qcxhome/gtg/bugfix-1218708/+merge/183075
Your team Gtg developers is requested to review the proposed merge of lp:~qcxhome/gtg/bugfix-1218708 into lp:gtg.

=== modified file 'GTG/gtk/editor/editor.py'
--- GTG/gtk/editor/editor.py	2013-08-25 20:07:47 +0000
+++ GTG/gtk/editor/editor.py	2013-08-30 05:52:29 +0000
@@ -177,10 +177,12 @@
             tid = self.task.get_id()
             if self.config.has_section(tid):
                 if self.config.has_option(tid, "position"):
-                    pos_x, pos_y = self.config.get(tid, "position")
+                    position = self.config.get(tid, "position")
+                    pos_x, pos_y = position[0].split(',')
                     self.move(int(pos_x), int(pos_y))
                 if self.config.has_option(tid, "size"):
-                    width, height = self.config.get(tid, "size")
+                    size = self.config.get(tid, "size")
+                    width, height = size[0].split(',')
                     self.window.resize(int(width), int(height))
 
         self.textview.set_editable(True)