← Back to team overview

gtg team mailing list archive

[Merge] lp:~sara.ribeiro/gtg/quickadd_tag_parser into lp:gtg

 

Sara Ribeiro has proposed merging lp:~sara.ribeiro/gtg/quickadd_tag_parser into lp:gtg.

Requested reviews:
  Gtg developers (gtg)
Related bugs:
  Bug #1288560 in Getting Things GNOME!: "Parsing error when creating a task (via quick add entry) that contains a tag with "&" in it"
  https://bugs.launchpad.net/gtg/+bug/1288560

For more details, see:
https://code.launchpad.net/~sara.ribeiro/gtg/quickadd_tag_parser/+merge/209584
-- 
https://code.launchpad.net/~sara.ribeiro/gtg/quickadd_tag_parser/+merge/209584
Your team Gtg developers is requested to review the proposed merge of lp:~sara.ribeiro/gtg/quickadd_tag_parser into lp:gtg.
=== modified file 'CHANGELOG'
--- CHANGELOG	2014-03-01 21:15:24 +0000
+++ CHANGELOG	2014-03-06 06:03:33 +0000
@@ -18,6 +18,7 @@
     * Fix for bug #1286491 : RTM sync backend fails to load, by Pawan Hegde
     * Fix for bug #1286493 : GTG cannot connect to RTM, by Pawan Hegde
     * Fix for bug #1288011 : More intuitive title label for tasks, by Sara Ribeiro
+    * Fix for bug #1288560 : Parsing error when creating a task (via quick add entry) that contains a tag with "&" in it, by Sara Ribeiro
 
 2013-11-24 Getting Things GNOME! 0.3.1
     * Fix for bug #1024473: Have 'Show Main Window' in notification area, by Antonio Roquentin

=== modified file 'GTG/tools/tags.py'
--- GTG/tools/tags.py	2013-11-23 14:40:23 +0000
+++ GTG/tools/tags.py	2014-03-06 06:03:33 +0000
@@ -22,7 +22,7 @@
 
 def extract_tags_from_text(text):
     """ Given a string, returns a list of the @tags contained in that """
-    return re.findall(r'(?:^|[\s])(@[\w\/\.\-\:]*\w)', text)
+    return re.findall(r'(?:^|[\s])(@[\w\/\.\-\:\&]*\w)', text)
 
 
 def parse_tag_list(text):


Follow ups