← Back to team overview

gwibber-bugs team mailing list archive

[Bug 1118574] [NEW] Support pillow and imaging

 

Public bug reported:

Python has two PIL provides, python-imaging and python-pillow. Fedora is
moving to python-pillow in the next release.

imaging supports being loaded by doing:

import Image

or

from PIL import Image

pillow only supports the latter, so we're patching all the calls to use
'from PIL import image'

Please apply the below changes! (They're against 3.4.2, but the code
hasn't changed in any real way.)

Index: gwibber-3.4.2/gwibber/microblog/util/imagehandler.py
===================================================================
--- gwibber-3.4.2.orig/gwibber/microblog/util/imagehandler.py
+++ gwibber-3.4.2/gwibber/microblog/util/imagehandler.py
@@ -1,6 +1,7 @@
 #!/usr/bin/env python
 
-import os, hashlib, urllib2, Image
+import os, hashlib, urllib2
+from PIL import Image
 
 DEFAULT_AVATAR = 'http://digg.com/img/udl.png'
 
Index: gwibber-3.4.2/gwibber/microblog/util/resources.py
===================================================================
--- gwibber-3.4.2.orig/gwibber/microblog/util/resources.py
+++ gwibber-3.4.2/gwibber/microblog/util/resources.py
@@ -8,7 +8,7 @@ import os, sys
 from hashlib import sha1
 from os import makedirs, remove, environ
 from os.path import join, isdir, realpath, exists
-import Image
+from PIL import Image
 import mx.DateTime
 from gwibber.microblog import network
 from gwibber.microblog.util.const import *

** Affects: gwibber
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Gwibber
Bug Heros, which is subscribed to Gwibber.
https://bugs.launchpad.net/bugs/1118574

Title:
  Support pillow and imaging

Status in Gwibber:
  New

Bug description:
  Python has two PIL provides, python-imaging and python-pillow. Fedora
  is moving to python-pillow in the next release.

  imaging supports being loaded by doing:

  import Image

  or

  from PIL import Image

  pillow only supports the latter, so we're patching all the calls to
  use 'from PIL import image'

  Please apply the below changes! (They're against 3.4.2, but the code
  hasn't changed in any real way.)

  Index: gwibber-3.4.2/gwibber/microblog/util/imagehandler.py
  ===================================================================
  --- gwibber-3.4.2.orig/gwibber/microblog/util/imagehandler.py
  +++ gwibber-3.4.2/gwibber/microblog/util/imagehandler.py
  @@ -1,6 +1,7 @@
   #!/usr/bin/env python
   
  -import os, hashlib, urllib2, Image
  +import os, hashlib, urllib2
  +from PIL import Image
   
   DEFAULT_AVATAR = 'http://digg.com/img/udl.png'
   
  Index: gwibber-3.4.2/gwibber/microblog/util/resources.py
  ===================================================================
  --- gwibber-3.4.2.orig/gwibber/microblog/util/resources.py
  +++ gwibber-3.4.2/gwibber/microblog/util/resources.py
  @@ -8,7 +8,7 @@ import os, sys
   from hashlib import sha1
   from os import makedirs, remove, environ
   from os.path import join, isdir, realpath, exists
  -import Image
  +from PIL import Image
   import mx.DateTime
   from gwibber.microblog import network
   from gwibber.microblog.util.const import *

To manage notifications about this bug go to:
https://bugs.launchpad.net/gwibber/+bug/1118574/+subscriptions


Follow ups

References