← Back to team overview

holland-coredev team mailing list archive

[Bug 1168507] Re: Feature Request: Allow additional arguments to compression method

 

This is a very reasonable request and something I had implemented for
the next major release.  I think this is worth implementing in holland
1.0.X.

I have pushed a feature branch here with the necessarily changes to
support this option syntax:

https://github.com/holland-
backup/holland/tree/configurable_compression_cmds

There is still a few edge cases to consider - particularly if a
compression command outputs a lot of information on stderr (possibly
with a --verbose option), where holland 1.0 currently has the
inappropriate assumption stderr=PIPE will suffice and this could cause a
"deadlock" scenario .  Documentation also remains to be updated for this
feature.  Once these are resolved this will be merged into upstream and
included in a future minor release.

I hope to have a next minor 1.0 release (v1.0.10) towards the end of
April and we should be able to include this feature then.

-- 
You received this bug notification because you are a member of Holland
Build, which is subscribed to holland-backup.
https://bugs.launchpad.net/bugs/1168507

Title:
  Feature Request: Allow additional arguments to compression method

Status in Holland Backup Framework:
  Triaged

Bug description:
  I would like to be able to pass additional arguments to the
  compression method to get added during the creation. Something like:

  [compression]
  method=pigz
  inline=yes
  level=3
  options="-p 40"

  The main reason is that pigz supports a "-p N" option to limit the
  number of threads (hence cores) that it will use when launched; this
  option capability will allow us to ensure there are cores reserved for
  MySQL to operate on during a massive pigz cycle that would normally
  utilize all 48 cores on a Production server.

To manage notifications about this bug go to:
https://bugs.launchpad.net/holland-backup/+bug/1168507/+subscriptions


References