holland-coredev team mailing list archive

[Andrew Garner <801691@xxxxxxxxxxxxxxxxxx>]

Just revisiting this as I was thinking about this previously.  I think
the best way forward here is to treat this as a comma-separated list of
commandlines, where we parse each comma-separated string as a
commandline.

So you can have messy configs like:

additional-options = --foo --bar, --baz

Which would be equivalent to:

additional-options = --foo --bar --baz

If a comma is required in an option, then quoting is needed:

additional-options = "--foo --bar --baz=,"

But this is the case already as configobj's list parsing is fairly
simple.

In 1.1+ we can catch this error in the validator and raise a deprecation
warning and eventually deprecate the comma separated approach entirely.

Still holding this sort of change off for a 1.1+ release.

-- 
You received this bug notification because you are a member of Holland
Build, which is subscribed to holland-backup.
https://bugs.launchpad.net/bugs/801691

Title:
  mysqldump additional-options behavior discrepancy

Status in Holland Backup Framework:
  In Progress
Status in holland-backup 1.0 series:
  New
Status in holland-backup 1.1 series:
  New

Bug description:
  The mysqldump plugin expects the 'additional-options' setting to
  provide a comma separated list.   However the configspec currently has
  a comment that notes this should be provided "exactly as on the
  command line".  This causes multiple options to be misinterpretted
  (and mysqldump will fail) and is confusing.   The
  comment/documentation at least needs to be clear on the format
  required here and possibly the implementation updated.

  Example:

  additional-options = --no-data, --routines # OK
  additional-options = --no-data --routines # misinterpreted as mysqldump "--no-data --routines"

To manage notifications about this bug go to:
https://bugs.launchpad.net/holland-backup/+bug/801691/+subscriptions