holland-coredev team mailing list archive

[Andrew Garner <1186992@xxxxxxxxxxxxxxxxxx>]

** Changed in: holland-backup
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Holland
Build, which is subscribed to holland-backup.
https://bugs.launchpad.net/bugs/1186992

Title:
  mysqldump plugin does not always close files

Status in Holland Backup Framework:
  Fix Released

Bug description:
  Through inspection and as part of bug 1168507, there are a few places
  where the mysqldump plugin is not careful about closing files.

  * when file-per-database = off
  * during the backup_data/MANIFEST.txt generation

  These need to be wrapped in a try ... finally block, particularly
  since these files are typically pipes to gzip (or some other
  compression command), and the process may never be checked/collected.

  Since we're still basing 1.0.X on python2.4 (at least), we can't use
  the more convenient context managers for this, so cumbersome try ...
  finally is the current solution here.

To manage notifications about this bug go to:
https://bugs.launchpad.net/holland-backup/+bug/1186992/+subscriptions