holland-coredev team mailing list archive

[Andrew Garner <1290495@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

mysql lvm --dry-run opens the archive stream to the temporary backup
directory through some dubious logic in setup_actions(...).

When the dry-run finishes it then attempts to remove this temporary
directory used for simulating the backup.  Under some filesystems (e.g.
NFS), this may fail as the directory is not empty - some other process,
probably the background compression command is still holding an open
file.

This is not noticed during a backup on a local filesystem, as rmdir
won't complain here even though the same problem is present.

The current LVM plugin logic is ridiculously convoluted.  Particularly
here, the job of opening the archive stream should be left to the tar
command, I think, and no files or anything heavyweight should really be
done in setup_actions(...).  This means passing somewhat more
information to the "TarArchiveAction" that is being done today.

** Affects: holland-backup
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Holland
Build, which is subscribed to holland-backup.
https://bugs.launchpad.net/bugs/1290495

Title:
  mysql lvm --dry-run holds open file

Status in Holland Backup Framework:
  New

Bug description:
  mysql lvm --dry-run opens the archive stream to the temporary backup
  directory through some dubious logic in setup_actions(...).

  When the dry-run finishes it then attempts to remove this temporary
  directory used for simulating the backup.  Under some filesystems
  (e.g. NFS), this may fail as the directory is not empty - some other
  process, probably the background compression command is still holding
  an open file.

  This is not noticed during a backup on a local filesystem, as rmdir
  won't complain here even though the same problem is present.

  The current LVM plugin logic is ridiculously convoluted.  Particularly
  here, the job of opening the archive stream should be left to the tar
  command, I think, and no files or anything heavyweight should really
  be done in setup_actions(...).  This means passing somewhat more
  information to the "TarArchiveAction" that is being done today.

To manage notifications about this bug go to:
https://bugs.launchpad.net/holland-backup/+bug/1290495/+subscriptions