← Back to team overview

hugin-devs team mailing list archive

[Bug 678842] Re: Stitcher canvas size, porportional change not bidirectional

 

I have two questions:-
1. Is it really  a bug? (read details below).
2. If yes, then please give suggestions how I should rectify it.

Initially after looking at Panopanel.cpp[1] file especially function at
Canvas Width and Height events(Line 73,74) and then looked for their
respective functions i.e. WidthChange[2] and HeightChange[3], I thought
there is just a typo in line 686(inside Height()) as it seemed that the
author missed to include m_KeepViewOnResize as its present in
WidthChange funtion), but build gave invalid parameter error for
HeightChange funtion.

So, I looked for their declaration and there I saw that the original author has coded it that way( I am assuming that he meant to do it in this way only as it does seems to be *just missed it* case.).
Please see the definitions of HuginBase::PanoramaOptions::setWidth[4] and SetHeight[5].

If it needs to be modified, then please suggest me what formula's and
condition should I use to modify the horizontal canvas size as I don't
have much knowledge of this

Cheers
Neeraj


[1] http://hugin.sourceforge.net/docs/html/PanoPanel_8cpp-source.html                                  PanoPanel.cpp
[2] http://hugin.sourceforge.net/docs/html/PanoPanel_8cpp-source.html#l00662                   Func-WidthChange
[3] http://hugin.sourceforge.net/docs/html/PanoPanel_8cpp-source.html#l00679                   Func- HeightChange
[4]http://hugin.sourceforge.net/docs/html/PanoramaOptions_8cpp-source.html#l00253      SetWidth
[5] http://hugin.sourceforge.net/docs/html/PanoramaOptions_8cpp-source.html#l00293      SetHeight

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/678842

Title:
  Stitcher canvas size, porportional change not bidirectional

Status in Hugin - Panorama Tools GUI:
  Confirmed

Bug description:
  Changing the horizonatal canvas size in the Stitcher results in a
  corresponding porportional vertical canvas size just as would be
  expected. The same is not true when changing the vertical canvas size.
  A vertical canvas size change does not change the horizontal canvas
  size and in fact appears to function as a crop.