← Back to team overview

hugin-devs team mailing list archive

[Bug 883166] Re: Move multiple images in ImageList

 

Thanks for trying this patch.. I've double checked but can't reproduce
the problem you report.

I've attached a comparison of the previous release moving a single image
up, and my local build moving a block of images up. When I select a
block of image and move then up, the SAME block of images remains
selected and pressing up again moves them further up the list. In both
cases, the focus is lost by the selection is retained.

By default, when the ImageList is re-ordered the selected locations
don't move. Without the patch the method ImagesList::SelectSingleImage
updated the selected image, in the patch I have modified this to re-
select the block. So I can't see that I've altered the behaviour in this
respect.

Which OS are you using?
Can you describe the problem you see in more detail? 

If you have four images(a,b,c & d) and you move the middle two up I
would expect that images b and c remain selected, but now in the top two
locations.

Imagine four images
a b c d

Select the middle two
a B C d

Move them up
B C a d

I can see one problem in the patch, I reset the focus onto the down
button in both cases but that doesn't cause your problem.

Regards
Stephen 

** Attachment added: "Comparioson of patch against previous release"
   https://bugs.launchpad.net/hugin/+bug/883166/+attachment/2581012/+files/Comparison.jpg

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/883166

Title:
  Move multiple images in ImageList

Status in Hugin - Panorama Tools GUI:
  New

Bug description:
  Request to be able to move blocks of selected images up and down the
  ImageList in the image Tab.

  Attached, a patch which demostrates how this could be done:
  Test if selected images form a continuous block, if not disable move buttons, otherwise allow block of images to be moved by repeated calls to SwapImagesCmd()... Wrap repeated calls using CombinedPanoCommand() to create a single item in the undo history.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/883166/+subscriptions


References