← Back to team overview

hugin-devs team mailing list archive

[Bug 936090] [NEW] cpfind does not handle "matrixmode" correctly.

 

Public bug reported:

I'm shooting panoramas in matrix mode. So I do a row, move to the next
row and then move along the row again.

for example 16 pictures might be taken as follows:

  0   1    2   3  
  7   6    5   4
  8   9  10 11
15 14 13 12

I use the "snake" algorithm to reduce the amount of movement of the
camera.

This means that every picture "n" is adjacent to picture "n+1",  but
also to some picture in the next row. I haven't managed to get cpfind's
matrixmode to analyse the correct image pairs.

Determining which images overlap with what others is something that
cpfind shouldn't be bothered with. I suggest cpfind implements "linear"
and "all" modes, but nothing else.

I have implemented a "--checkmatchesfile" option.  If specified cpfind
will load the image pairs to check from the file.

For now I "manually" created the pairs-file with a simple shell script.
However the hugin fast preview layout window also "knows" what image
pairs overlap. It can easily be modified to output this file! In my case
I've also written a script that will create an initial layout for an
empty PTO file. The fast preview/layout window will then know
"instantly" which images overlap, and should be able to output a nice
checkmatchesfile for me.

The improvement in quality of the resulting layout is enormous! 
(it also seems that my checkmatches list is much shorter than the matrix mode default, so it runs faster too. )


I must admit that my C++ skills are a bit lacking. The ugliest part is in PanoDetector::prepareMatches . There I mostly use C to read the checkmatches file. Someone fluent in C++ can easily translate that to C++. 

The patch also corrects a typo in RANSACOptimizer::Mode getRansacMode .
(the name was "setRan...")

** Affects: hugin
     Importance: High
         Status: Triaged


** Tags: cpfind matrixmode

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/936090

Title:
  cpfind does not handle "matrixmode" correctly.

Status in Hugin - Panorama Tools GUI:
  Triaged

Bug description:
  I'm shooting panoramas in matrix mode. So I do a row, move to the next
  row and then move along the row again.

  for example 16 pictures might be taken as follows:

    0   1    2   3  
    7   6    5   4
    8   9  10 11
  15 14 13 12

  I use the "snake" algorithm to reduce the amount of movement of the
  camera.

  This means that every picture "n" is adjacent to picture "n+1",  but
  also to some picture in the next row. I haven't managed to get
  cpfind's matrixmode to analyse the correct image pairs.

  Determining which images overlap with what others is something that
  cpfind shouldn't be bothered with. I suggest cpfind implements
  "linear" and "all" modes, but nothing else.

  I have implemented a "--checkmatchesfile" option.  If specified cpfind
  will load the image pairs to check from the file.

  For now I "manually" created the pairs-file with a simple shell
  script. However the hugin fast preview layout window also "knows" what
  image pairs overlap. It can easily be modified to output this file! In
  my case I've also written a script that will create an initial layout
  for an empty PTO file. The fast preview/layout window will then know
  "instantly" which images overlap, and should be able to output a nice
  checkmatchesfile for me.

  The improvement in quality of the resulting layout is enormous! 
  (it also seems that my checkmatches list is much shorter than the matrix mode default, so it runs faster too. )

  
  I must admit that my C++ skills are a bit lacking. The ugliest part is in PanoDetector::prepareMatches . There I mostly use C to read the checkmatches file. Someone fluent in C++ can easily translate that to C++. 

  The patch also corrects a typo in RANSACOptimizer::Mode getRansacMode
  . (the name was "setRan...")

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/936090/+subscriptions


Follow ups

References