hugin-devs team mailing list archive

[tduell <1271563@xxxxxxxxxxxxxxxxxx>]

Hello Thomas,

On Thu, 30 Jan 2014 05:13:17 +1100, tmodes <1271563@xxxxxxxxxxxxxxxxxx>  
wrote:

> Hi Terry,
>
> 1.) we have already a lot of top level folders. These files should go
> into platform/linux/appdata or the like.

OK.

>
> 2.) This should not go into the main CMakeLists.txt. It should go into a
> CMakeLists.txt in the above folder. And then it needs to be included
> with ADD_SUBDIRECTORY
>

OK

> 3.) SET(APPDATA_DIR ${PROJECT_SOURCE_DIR}/appdata): This is not
> necessary. The paths are always relative to the CMakeLists.txt in which
> the line are. So appdata/hugin.appdata.xml would be enough. No need to
> expand to full path.
>

OK

> 4.)  SET(INST_APPDATA_DIR share/appdata) Please use the naming
> conventions for the variable in the file: BINDIR, LIBDIR and DATADIR
> (without underscore, without INST). Maybe the variable is not needed.
> You can use INSTALL for several files at once.
>

OK

> 5.) Is the path correct: By default they will be installed in
> /usr/local/share/appdata. Is this correct? Or should they installed into
> /usr/share/appdata?
>

The requirement is for installation into /usr/share/appdata

> 6.) Best is to provide a diff file instead of copy and paste. (Use 'hg
> diff' to create diff file.) This is easier to handle for other than to
> copy your text by hand.
>

OK.

Cheers,
-- 
Regards,
Terry Duell

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/1271563

Title:
  Please provide an AppData file

Status in Hugin - Panorama Tools GUI:
  Confirmed

Bug description:
  Please add a AppData file for Hugin, else it looks really bad in the
  GNOME Software Center. See
  http://people.freedesktop.org/~hughsient/appdata/ for details; thanks!

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/1271563/+subscriptions