hugin-devs team mailing list archive

[tduell <1271563@xxxxxxxxxxxxxxxxxx>]

Hello Thomas,

>
> * it still install into /usr/local/share/appdata. If you want to install
> into a fixed folder you need to give the fixed path. DATADIR expands to
> CMAKE_INSTALL_PREFIX/share and the default CMAKE_INSTALL_PREFIX is
> /usr/local.
>

My mistake, sorry. Tested here within rpmbuild environment, which  
separately manages packaging.

> * please provide only a single diff file with the changes to all files.
> This is easier to handle.

OK, if that is preferred.

>
> * The last one is more a style questions: we don't use add_subdirectory
> over several levels. This requires some more changes, but it easier to
> maintain.
>
> ** Patch added: "install_appdata.diff"
>    https://bugs.launchpad.net/hugin/+bug/1271563/+attachment/3962883/+files/install_appdata.diff
>

OK, thanks.

I'll try to fix all that, and post diff for your comments.

Cheers,
-- 
Regards,
Terry Duell

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/1271563

Title:
  Please provide an AppData file

Status in Hugin - Panorama Tools GUI:
  Confirmed

Bug description:
  Please add a AppData file for Hugin, else it looks really bad in the
  GNOME Software Center. See
  http://people.freedesktop.org/~hughsient/appdata/ for details; thanks!

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/1271563/+subscriptions