hugin-devs team mailing list archive

[tmodes <1508898@xxxxxxxxxxxxxxxxxx>]

Thanks for the patch. But I had to rework it:
* strtof is only supported by C++11, but we don't enforce C++11
* strtolvl has nothing to do with ImageRemapper and should therefore moved out of this file
* The variables names  m_clipExpMaskUELvl and m_clipExpMaskOELvl (and other) are completely unreadable (UEL is lower level/cutoff, OEL is upper level; what is U and what is O -> please use english words).
* The input should by checked by the calling program and not passed deep into further function and then silently ignored if there are invalid inputs. There is no feedback for the user that something is wrong.
* The default values are used in several places in several different formats:
 m_clipExpMaskUELvl(1/255.0f), m_clipExpMaskOELvl(250/255.0f) vs. 
static const std::string uelvlDef("0.00392156862745098"); static const std::string oelvlDef("0.980392156862745");
* We have already enough options. Don't introduce 2 more options for a "minor" feature.

Committed as changeset 7d1e8251d212.

** Changed in: hugin
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/1508898

Title:
  Parameterization of nona "--clip-exposure" option

Status in Hugin:
  Fix Committed

Bug description:
  For now nona has hardcoded dark and bright pixel levels for "--clip-
  exposure" option. IMHO, it could be helpful to make these levels are
  modifiable by the user. The patch in the attachment adds two command
  line options ("--dark-level" and "--bright-level") to set dark and
  bright pixel levels.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/1508898/+subscriptions