← Back to team overview

hugin-devs team mailing list archive

[Bug 1508898] Re: Parameterization of nona "--clip-exposure" option

 

Thank you.
As I see, there are several copies of an "HugeBase::Nona::AdvancedOptions" object in many instances of other classes.
I made a minor changes in the "HuginBase::NonaFileOutputStitcher", "HuginBase::Nona::SingleImageRemapper", "HuginBase::Nona::FileRemapper" and "HuginBase::Nona::RemappedPanoImage" classes to hold a const references to a single instance of HuginBase::Nona::AdvancedOptions.
Please look at the attached patch.

** Patch added: "makes all classes referenceses the single instance of HuginBase::Nona::AdvancedOptions"
   https://bugs.launchpad.net/hugin/+bug/1508898/+attachment/4507451/+files/nona-advanced-options.diff.gz

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/1508898

Title:
  Parameterization of nona "--clip-exposure" option

Status in Hugin:
  Fix Committed

Bug description:
  For now nona has hardcoded dark and bright pixel levels for "--clip-
  exposure" option. IMHO, it could be helpful to make these levels are
  modifiable by the user. The patch in the attachment adds two command
  line options ("--dark-level" and "--bright-level") to set dark and
  bright pixel levels.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/1508898/+subscriptions


References