hugin-devs team mailing list archive

[tmodes <1508898@xxxxxxxxxxxxxxxxxx>]

> As I see, there are several copies of an 
> "HugeBase::Nona::AdvancedOptions" object..

I agree that it would be nice to keep only a reference to one instance.
But your implementation makes it more convoluted. You add a completely
new class RemappedFileImage  for this minor function and add no-op
functions to existing classes. (e.g. exposureClipMaskEnabled and
related). So now there are two classes RemappedPanoImage and
RemappedFileImage with newly the same functionality.

> Comparing a minimum of red, green, and blue values ..
If only one channel has an over- or underflow you will get a color cast when doing exposure compensation. So the correction should be okay.

> Attached patch makes this default.
Have you tested your patch? There is at least one typo:
utils.c: +CutoffVal stringToCutoffVal(const std::string &str)
utils.h: +IMPEX CutoffVal strngToCutoffVal(const std::string &str);

You found another way to pass an option to nona. But this option is
completely undocumented, so it is mostly unusable for the common user.

For each pixel you are now calling  "switch (cv)..". This can have
impact on performance.

And more important: what issue do you want solve which this new switch
with so many options?

We have already many options. So adding a new option should add a
substantial new function.

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/1508898

Title:
  Parameterization of nona "--clip-exposure" option

Status in Hugin:
  Fix Committed

Bug description:
  For now nona has hardcoded dark and bright pixel levels for "--clip-
  exposure" option. IMHO, it could be helpful to make these levels are
  modifiable by the user. The patch in the attachment adds two command
  line options ("--dark-level" and "--bright-level") to set dark and
  bright pixel levels.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/1508898/+subscriptions