hugin-devs team mailing list archive

[Iouri Ivliev <lp@xxxxxxxxxx>]

> Have you tested your patch? There is at least one typo:
Yes of course. It works as expected.

> utils.c: +CutoffVal stringToCutoffVal(const std::string &str)
> utils.h: +IMPEX CutoffVal strngToCutoffVal(const std::string &str); 
It's all right. The second line is a declaration and the first one is a definition. "IMPEX" macro be expanded (for Windows) into "__declspec(dllexport)" when building DLL or into "__declspec(dllimport)" when using function from DLL. This clauses are need only for declarations, not for definitions.

> You found another way to pass an option to nona. But this option is completely undocumented, so it is mostly unusable for the common user.
I do not quite understand what you mean by "completely undocumented", but as I wrote above it's a "quick'n'dirty hack". I don't know how to pass these parameters so that it was "The Right Thing". The simplest way is to use environment variables.

> For each pixel you are now calling "switch (cv)..". This can have impact on performance.
Yes you are right. This needs to be optimized.

> And more important: what issue do you want solve which this new switch with so many options?
As wrote above, I have an image with a bright blue sky (rgb(0,6, 0,85, 0,99)) and a grass in the shade (rgb(0.05, 0.2, 0.001)). Also this image contains deep shades (from rgb(0, 0, 0) to rgb(0.002, 0.002, 0.002) and overexposed highlights (from rgb(0,985, 0,985, 0,985) to rgb(1, 1, 1). It's a part of middle row in spherical panorama. So, its deep shades are normally exposed in the bottom row, and highlights in the top one. I want to cut shades and highlights, but keep the grass and a part of normally exposed sky. Of course, I can do it, drawing masks by hand, but I would like to automate it.

But it seems that I have chosen the wrong tool. Now I realized that I
needed something else. Namely, the ability to automatically create
vector masks by different criteria, so that later to edit them in the
Hugins "Masks/Crop" tool, if necessary. Thanks a lot, you have helped me
to understand what I want really. And I know how to do that. Sorry that
wasting your time.

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/1508898

Title:
  Parameterization of nona "--clip-exposure" option

Status in Hugin:
  Fix Committed

Bug description:
  For now nona has hardcoded dark and bright pixel levels for "--clip-
  exposure" option. IMHO, it could be helpful to make these levels are
  modifiable by the user. The patch in the attachment adds two command
  line options ("--dark-level" and "--bright-level") to set dark and
  bright pixel levels.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/1508898/+subscriptions