hugin-devs team mailing list archive

[tmodes <1508898@xxxxxxxxxxxxxxxxxx>]

I know what the IMPEX macros does (I have implemented it ;-). This was not the point. Slightly reformatted:
> utils.c: +           CutoffVal stringToCutoffVal(const std::string &str)
> utils.h: +IMPEX CutoffVal strngToCutoffVal(const std::string &str);

stringToCutoffVal <> strngToCutoffVal

Okay, I got the point. Yes, we were talking from different points: --clip-exposure works *before* the photometric correction (to prevent color cast in correction). But you were referring to a post-photometric correction mask. Modifying the --clip-exposure switch would not help in your use case, because the photometric correction would modify the color values and you would get not the desired result.
Maybe we could change it: --clip-exposure becomes --clip-exposure-before-photometric and we add an additional switch --clip-exposure-after-photometric to work additional after the photometric correction and add additional switch to select the projector.

> Sorry that wasting your time.
You have not wasted my time. Thinking on it and discussing it can improve Hugin for all of us.

PS: If you can use enfuse in your workflow, there is already a similar switch in enfuse
--exposure-cutoff=LOWER-CUTOFF:UPPER-CUTOFF:LOWER-PROJECTOR:UPPER-PROJECTOR
So no need to implement it for yourself.

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/1508898

Title:
  Parameterization of nona "--clip-exposure" option

Status in Hugin:
  Fix Committed

Bug description:
  For now nona has hardcoded dark and bright pixel levels for "--clip-
  exposure" option. IMHO, it could be helpful to make these levels are
  modifiable by the user. The patch in the attachment adds two command
  line options ("--dark-level" and "--bright-level") to set dark and
  bright pixel levels.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/1508898/+subscriptions