← Back to team overview

hugin-devs team mailing list archive

[Bug 1538247] [NEW] Wrong order of member initializers

 

Public bug reported:

While compiling with "g++ -Wall" a lot of warnings of this type are
reported:

In file included from d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.cpp:57:0:
d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.h: In constructor 'MyExecPanel::MyExecPanel(wxWindow*)':
d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.h:110:10: warning: 'MyExecPanel::m_checkReturnCode' will be initialized after [-Wreorder]
     bool m_checkReturnCode;
          ^
d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.h:108:12: warning:   'size_t MyExecPanel::m_queueLength' [-Wreorder]
     size_t m_queueLength;
            ^
d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.cpp:77:1: warning:   when initialized here [-Wreorder]
 MyExecPanel::MyExecPanel(wxWindow * parent)
 ^

More info is here: http://stackoverflow.com/questions/1828037/whats-the-
point-of-g-wreorder

The patch is attached.

Regards,
/J.D.

** Affects: hugin
     Importance: Undecided
         Status: New

** Attachment added: "Wreorder_patches.zip"
   https://bugs.launchpad.net/bugs/1538247/+attachment/4556974/+files/Wreorder_patches.zip

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/1538247

Title:
  Wrong order of member initializers

Status in Hugin:
  New

Bug description:
  While compiling with "g++ -Wall" a lot of warnings of this type are
  reported:

  In file included from d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.cpp:57:0:
  d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.h: In constructor 'MyExecPanel::MyExecPanel(wxWindow*)':
  d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.h:110:10: warning: 'MyExecPanel::m_checkReturnCode' will be initialized after [-Wreorder]
       bool m_checkReturnCode;
            ^
  d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.h:108:12: warning:   'size_t MyExecPanel::m_queueLength' [-Wreorder]
       size_t m_queueLength;
              ^
  d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.cpp:77:1: warning:   when initialized here [-Wreorder]
   MyExecPanel::MyExecPanel(wxWindow * parent)
   ^

  More info is here: http://stackoverflow.com/questions/1828037/whats-
  the-point-of-g-wreorder

  The patch is attached.

  Regards,
  /J.D.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/1538247/+subscriptions


Follow ups