hugin-devs team mailing list archive

[Jan Dubiec <1538247@xxxxxxxxxxxxxxxxxx>]

Ooops, I've just noticed that you have already applied the patches.

Next patches will be in the form of a single file. They will be rather
cosmetic because I try to fix warnings reported by -Wall option. Some of
them are annoying, eg. like warning about signed/unsigned comparison in
templates:

In file included from D:/Works/Hugin/src/hugin_base/nona/RemappedPanoImage.h:190:0,
                 from D:/Works/Hugin/src/hugin_base/nona/ImageRemapper.h:32,
                 from d:/Works/Hugin/src/hugin_base/huginapp/CachedImageRemapper.h:28,
                 from d:/Works/Hugin/src/hugin_base/huginapp/CachedImageRemapper.cpp:27:
D:/Works/Hugin/src/hugin_base/photometric/ResponseTransform.h: In instantiation of 'void HuginBase::Photometric::InvResponseTransform<VTIn, VTOut>::emitGLSL(std::ostringstream&, std::vector<double>&, std::vector<double>&) const [with VTIn = float; VTOut = double; std::ostringstream = std::__cxx11::basic_ostringstream<char>]':
D:/Works/Hugin/src/hugin_base/vigra_ext/ImageTransformsGPU.h:295:5:   required from 'void vigra_ext::transformImageAlphaGPUIntern(vigra::triple<Iterator, Iterator, Accessor>, std::pair<MaskIterator, MaskAccessor>, vigra::triple<DestImageIterator, DestImageIterator, DestAccessor>, std::pair<AlphaImageIterator, AlphaAccessor>, TRANSFORM&, PixelTransform&, vigra::Diff2D, Interpolator, bool, AppBase::ProgressDisplay*) [with SrcImageIterator = vigra::ConstBasicImageIterator<vigra::RGBValue<float>, vigra::RGBValue<float>**>; SrcAccessor = vigra::RGBAccessor<vigra::RGBValue<float> >; SrcAlphaIterator = vigra::ConstBasicImageIterator<unsigned char, unsigned char**>; SrcAlphaAccessor = vigra::StandardConstValueAccessor<unsigned char>; DestImageIterator = vigra::BasicImageIterator<vigra::RGBValue<float>, vigra::RGBValue<float>**>; DestAccessor = vigra::RGBAccessor<vigra::RGBValue<float> >; TRANSFORM = HuginBase::PTools::Transform; PixelTransform = HuginBase::Photometric::InvResponseTransform<float, double>; AlphaImageIterator = vigra::BasicImageIterator<unsigned char, unsigned char**>; AlphaAccessor = vigra::StandardValueAccessor<unsigned char>; Interpolator = vigra_ext::interp_cubic]'
D:/Works/Hugin/src/hugin_base/vigra_ext/ImageTransformsGPU.h:550:30:   required from 'void vigra_ext::transformImageAlphaGPU(vigra::triple<Iterator, Iterator, Accessor>, std::pair<MaskIterator, MaskAccessor>, vigra::triple<DestImageIterator, DestImageIterator, DestAccessor>, std::pair<AlphaImageIterator, AlphaAccessor>, vigra::Diff2D, TRANSFORM&, PixelTransform&, bool, vigra_ext::Interpolator, AppBase::ProgressDisplay*) [with SrcImageIterator = vigra::ConstBasicImageIterator<vigra::RGBValue<float>, vigra::RGBValue<float>**>; SrcAccessor = vigra::RGBAccessor<vigra::RGBValue<float> >; SrcAlphaIterator = vigra::ConstBasicImageIterator<unsigned char, unsigned char**>; SrcAlphaAccessor = vigra::StandardConstValueAccessor<unsigned char>; DestImageIterator = vigra::BasicImageIterator<vigra::RGBValue<float>, vigra::RGBValue<float>**>; DestAccessor = vigra::RGBAccessor<vigra::RGBValue<float> >; AlphaImageIterator = vigra::BasicImageIterator<unsigned char, unsigned char**>; AlphaAccessor = vigra::StandardValueAccessor<unsigned char>; TRANSFORM = HuginBase::PTools::Transform; PixelTransform = HuginBase::Photometric::InvResponseTransform<float, double>]'
D:/Works/Hugin/src/hugin_base/nona/RemappedPanoImage.h:706:46:   required from 'void HuginBase::Nona::RemappedPanoImage<RemapImage, AlphaImage>::remapImage(vigra::triple<ImgIter, ImgIter, ImgAccessor>, std::pair<AlphaIter, AlphaAccessor>, vigra_ext::Interpolator, AppBase::ProgressDisplay*, bool) [with ImgIter = vigra::ConstBasicImageIterator<vigra::RGBValue<float>, vigra::RGBValue<float>**>; ImgAccessor = vigra::RGBAccessor<vigra::RGBValue<float> >; AlphaIter = vigra::ConstBasicImageIterator<unsigned char, unsigned char**>; AlphaAccessor = vigra::StandardConstValueAccessor<unsigned char>; RemapImage = vigra::BasicImage<vigra::RGBValue<float> >; AlphaImage = vigra::BasicImage<unsigned char>]'
D:/Works/Hugin/src/hugin_base/nona/RemappedPanoImage.h:800:9:   required from 'void HuginBase::Nona::remapImage(SrcImgType&, const MaskImgType&, const FlatImgType&, const HuginBase::SrcPanoImage&, const HuginBase::PanoramaOptions&, vigra::Rect2D, HuginBase::Nona::RemappedPanoImage<DestImgType, MaskImgType>&, AppBase::ProgressDisplay*) [with SrcImgType = vigra::BasicImage<vigra::RGBValue<float> >; FlatImgType = vigra::BasicImage<float>; DestImgType = vigra::BasicImage<vigra::RGBValue<float> >; MaskImgType = vigra::BasicImage<unsigned char>]'
d:/Works/Hugin/src/hugin_base/huginapp/CachedImageRemapper.cpp:141:28:   required from here
D:/Works/Hugin/src/hugin_base/photometric/ResponseTransform.h:566:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (int i = 0; i < Base::m_lutR.size(); i++) {
                       ^

It takes some effort to understand this.

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/1538247

Title:
  Wrong order of member initializers

Status in Hugin:
  Fix Committed

Bug description:
  While compiling with "g++ -Wall" a lot of warnings of this type are
  reported:

  In file included from d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.cpp:57:0:
  d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.h: In constructor 'MyExecPanel::MyExecPanel(wxWindow*)':
  d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.h:110:10: warning: 'MyExecPanel::m_checkReturnCode' will be initialized after [-Wreorder]
       bool m_checkReturnCode;
            ^
  d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.h:108:12: warning:   'size_t MyExecPanel::m_queueLength' [-Wreorder]
       size_t m_queueLength;
              ^
  d:/Works/Hugin/src/hugin1/base_wx/MyExternalCmdExecDialog.cpp:77:1: warning:   when initialized here [-Wreorder]
   MyExecPanel::MyExecPanel(wxWindow * parent)
   ^

  More info is here: http://stackoverflow.com/questions/1828037/whats-
  the-point-of-g-wreorder

  The patch is attached.

  Regards,
  /J.D.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/1538247/+subscriptions