← Back to team overview

hugin-devs team mailing list archive

[Bug 1892420] Re: levmar uses BLAS when built with LAPACK, but Hugin does not link against BLAS

 

Thank you for taking a look.

Gentoo's package manager removes that file in favour of the one provided
by CMake itself:

❯ q file -v /usr/share/cmake/Modules/FindLAPACK.cmake
dev-util/cmake-3.18.1: /usr/share/cmake/Modules/FindLAPACK.cmake

Now one might argue that CMake is correct in having the LAPACK target
only include the LAPACK library and not BLAS, since programs using BLAS
should probably explicitly link against the BLAS target.

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/1892420

Title:
  levmar uses BLAS when built with LAPACK, but Hugin does not link
  against BLAS

Status in Hugin:
  Incomplete
Status in hugin package in Gentoo Linux:
  New

Bug description:
  ```
  hugin-2019.2.0/src/foreign/levmar/misc_core.c:45:#define GEMM LM_MK_BLAS_NAME(gemm)
  ```

  This function is a BLAS function:
  https://en.wikipedia.org/wiki/Basic_Linear_Algebra_Subprograms#Level_3

  Thus, since levmar is built as a static library, Hugin itself should
  call `find_package(BLAS)` and `huginbase` should link against
  `BLAS_LIBRARIES`.

  Attached patch fixes this (in an admittedly slightly crude way) for
  me.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/1892420/+subscriptions


References