hugin-devs team mailing list archive

[tmodes <1892420@xxxxxxxxxxxxxxxxxx>]

If I request CMake to use a library I assume it returns all needed libraries to use the requested library - so I have not to check which other libs the requested library is using internal. 
So FindPackage should hide the internal details for the user - this is what our own FindLAPACK does. 

Also looking into CMakes own FindLAPACK:
at the beginning there is a note:
``LAPACK_LIBRARIES``  uncached list of libraries (using full path name) to link against  to use LAPACK
as I wrote above.
Also scrolling down I find:
find_package(BLAS)
So also CMake own FindLAPACK should also find BLAS.

I tested now also on Ubuntu. Our own FindLAPACK and also CMake FindLAPACK include both the BLAS library in the LAPACK_LIBRARIES (both tested!)
>From the log:
LAPACK found (/usr/lib/i386-linux-gnu/liblapack.so;/usr/lib/i386-linux-gnu/libblas.so)

So - without more information - I don't see the point of explicitly searching for BLAS.
So maybe Gentoo is also modifying files in CMake(?)/LAPACK(?)/BLAS(?) - as deleting the file in Hugins build system, which breaks then later.

** Changed in: hugin
       Status: Incomplete => Invalid

-- 
You received this bug notification because you are a member of Hugin
Developers, which is subscribed to Hugin.
https://bugs.launchpad.net/bugs/1892420

Title:
  levmar uses BLAS when built with LAPACK, but Hugin does not link
  against BLAS

Status in Hugin:
  Invalid
Status in hugin package in Gentoo Linux:
  New

Bug description:
  ```
  hugin-2019.2.0/src/foreign/levmar/misc_core.c:45:#define GEMM LM_MK_BLAS_NAME(gemm)
  ```

  This function is a BLAS function:
  https://en.wikipedia.org/wiki/Basic_Linear_Algebra_Subprograms#Level_3

  Thus, since levmar is built as a static library, Hugin itself should
  call `find_package(BLAS)` and `huginbase` should link against
  `BLAS_LIBRARIES`.

  Attached patch fixes this (in an admittedly slightly crude way) for
  me.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hugin/+bug/1892420/+subscriptions