← Back to team overview

kernel-packages team mailing list archive

[Bug 1453848] [NEW] Compilation warning on Utopic

 

Public bug reported:

[Impact]

When compiling the Utopic kernel, the following warning can is shown:

/tmp/kernel-henrix-EluZkimP/build/fs/exec.c: In function 'do_open_exec':
/tmp/kernel-henrix-EluZkimP/build/fs/exec.c:780:18: warning: passing argument 1 of 'trace_open_exec' from incompatible pointer type
  trace_open_exec(name);
                  ^
In file included from /tmp/kernel-henrix-EluZkimP/build/include/trace/syscall.h:4:0,
                 from /tmp/kernel-henrix-EluZkimP/build/include/linux/syscalls.h:80,
                 from /tmp/kernel-henrix-EluZkimP/build/fs/exec.c:48:
/tmp/kernel-henrix-EluZkimP/build/include/linux/tracepoint.h:163:21: note: expected 'const char *' but argument is of type 'struct filename *'
  static inline void trace_##name(proto)    \
                     ^
/tmp/kernel-henrix-EluZkimP/build/include/linux/tracepoint.h:270:3: note: in expansion of macro '__DECLARE_TRACE'
   __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), 1, \
   ^
/tmp/kernel-henrix-EluZkimP/build/include/linux/tracepoint.h:404:2: note: in expansion of macro 'DECLARE_TRACE'
  DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
  ^
/tmp/kernel-henrix-EluZkimP/build/include/trace/events/fs.h:32:1: note: in expansion of macro 'TRACE_EVENT'
 TRACE_EVENT(open_exec,
 ^

This is due to a wrong parameter type being used while invoking
trace_open_exec()

[Test Case]

A simple compilation of the kernel shows this warning.

[Fix]

A patch with the following should fix it:

-       trace_open_exec(name);
+       trace_open_exec(name->name);

** Affects: linux (Ubuntu)
     Importance: Low
     Assignee: Luis Henriques (henrix)
         Status: Triaged

** Affects: linux (Ubuntu Utopic)
     Importance: Undecided
     Assignee: Luis Henriques (henrix)
         Status: Triaged

** Also affects: linux (Ubuntu Utopic)
   Importance: Undecided
       Status: New

** Changed in: linux (Ubuntu Utopic)
       Status: New => Triaged

** Changed in: linux (Ubuntu Utopic)
     Assignee: (unassigned) => Luis Henriques (henrix)

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1453848

Title:
  Compilation warning on Utopic

Status in linux package in Ubuntu:
  Triaged
Status in linux source package in Utopic:
  Triaged

Bug description:
  [Impact]

  When compiling the Utopic kernel, the following warning can is shown:

  /tmp/kernel-henrix-EluZkimP/build/fs/exec.c: In function 'do_open_exec':
  /tmp/kernel-henrix-EluZkimP/build/fs/exec.c:780:18: warning: passing argument 1 of 'trace_open_exec' from incompatible pointer type
    trace_open_exec(name);
                    ^
  In file included from /tmp/kernel-henrix-EluZkimP/build/include/trace/syscall.h:4:0,
                   from /tmp/kernel-henrix-EluZkimP/build/include/linux/syscalls.h:80,
                   from /tmp/kernel-henrix-EluZkimP/build/fs/exec.c:48:
  /tmp/kernel-henrix-EluZkimP/build/include/linux/tracepoint.h:163:21: note: expected 'const char *' but argument is of type 'struct filename *'
    static inline void trace_##name(proto)    \
                       ^
  /tmp/kernel-henrix-EluZkimP/build/include/linux/tracepoint.h:270:3: note: in expansion of macro '__DECLARE_TRACE'
     __DECLARE_TRACE(name, PARAMS(proto), PARAMS(args), 1, \
     ^
  /tmp/kernel-henrix-EluZkimP/build/include/linux/tracepoint.h:404:2: note: in expansion of macro 'DECLARE_TRACE'
    DECLARE_TRACE(name, PARAMS(proto), PARAMS(args))
    ^
  /tmp/kernel-henrix-EluZkimP/build/include/trace/events/fs.h:32:1: note: in expansion of macro 'TRACE_EVENT'
   TRACE_EVENT(open_exec,
   ^

  This is due to a wrong parameter type being used while invoking
  trace_open_exec()

  [Test Case]

  A simple compilation of the kernel shows this warning.

  [Fix]

  A patch with the following should fix it:

  -       trace_open_exec(name);
  +       trace_open_exec(name->name);

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1453848/+subscriptions


Follow ups

References