kernel-packages team mailing list archive

[Luis Henriques <luis.henriques@xxxxxxxxxxxxx>]

Public bug reported:

The drivers/acpi/battery.c init function starts with:

static int __init acpi_battery_init(void)
{
	if (acpi_disabled)
		return;
[ ... ]

This could cause problems because, if ACPI is disabled, the driver init
function would return 0 (success) without being initialised.

The following compiler warning is shown when compiling Precise kernel:

/home/henrix/src/precise/ubuntu-precise/drivers/acpi/battery.c: In function 'acpi_battery_init':
/home/henrix/src/precise/ubuntu-precise/drivers/acpi/battery.c:1172:3: warning: 'return' with no value, in function returning non-void [-Wreturn-type]

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: linux-image-3.2.0-56-generic 3.2.0-56.86
ProcVersionSignature: Ubuntu 3.2.0-56.86-generic 3.2.51
Uname: Linux 3.2.0-56-generic x86_64
AlsaVersion: Advanced Linux Sound Architecture Driver Version 1.0.24.
ApportVersion: 2.0.1-0ubuntu17.1
Architecture: amd64
AudioDevicesInUse:
 USER        PID ACCESS COMMAND
 /dev/snd/controlC2:  ubuntu     1607 F.... pulseaudio
 /dev/snd/controlC1:  ubuntu     1607 F.... pulseaudio
 /dev/snd/controlC0:  ubuntu     1607 F.... pulseaudio
CRDA: Error: command ['iw', 'reg', 'get'] failed with exit code 1: nl80211 not found.
Card0.Amixer.info:
 Card hw:0 'Intel'/'HDA Intel at 0xfebf0000 irq 45'
   Mixer name	: 'Generic 1af4 ID 21'
   Components	: 'HDA:1af40021,1af40021,00100101'
   Controls      : 1
   Simple ctrls  : 1
Card1.Amixer.info:
 Card hw:1 'I82801AAICH'/'Intel 82801AA-ICH with STAC9700,83,84 at irq 11'
   Mixer name	: 'SigmaTel STAC9700,83,84'
   Components	: 'AC97a:83847600'
   Controls      : 8
   Simple ctrls  : 12
Card2.Amixer.info:
 Card hw:2 'AudioPCI'/'Ensoniq AudioPCI ENS1370 at 0xc400, irq 10'
   Mixer name	: 'Asahi Kasei AK4531'
   Components	: 'AK4531'
   Controls      : 43
   Simple ctrls  : 15
Date: Fri Nov  1 15:15:26 2013
HibernationDevice: RESUME=UUID=fb857da5-f276-48a8-a960-9e268be368ca
InstallationMedia: Ubuntu 12.04.1 LTS "Precise Pangolin" - Release amd64+mac (20120823.1)
IwConfig:
 lo        no wireless extensions.
 
 eth0      no wireless extensions.
Lsusb: Error: command ['lsusb'] failed with exit code 1: unable to initialize libusb: -99
MachineType: Bochs Bochs
MarkForUpload: True
ProcEnviron:
 TERM=xterm
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcFB: 0 EFI VGA
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.2.0-56-generic root=UUID=4aa0ea77-9f66-4074-a28f-6f808346c7a6 ro console=ttyS0
RelatedPackageVersions:
 linux-restricted-modules-3.2.0-56-generic N/A
 linux-backports-modules-3.2.0-56-generic  N/A
 linux-firmware                            1.79.7
RfKill:
 
SourcePackage: linux
StagingDrivers: zram
UpgradeStatus: No upgrade log present (probably fresh install)
dmi.bios.date: 01/01/2011
dmi.bios.vendor: Bochs
dmi.bios.version: Bochs
dmi.chassis.type: 1
dmi.chassis.vendor: Bochs
dmi.modalias: dmi:bvnBochs:bvrBochs:bd01/01/2011:svnBochs:pnBochs:pvr:cvnBochs:ct1:cvr:
dmi.product.name: Bochs
dmi.sys.vendor: Bochs

** Affects: linux (Ubuntu)
     Importance: Undecided
     Assignee: Luis Henriques (henrix)
         Status: Confirmed

** Affects: linux (Ubuntu Precise)
     Importance: Undecided
     Assignee: Luis Henriques (henrix)
         Status: Triaged


** Tags: amd64 apport-bug package-from-proposed precise running-unity staging

** Patch added: "UBUNTU: SAUCE: ACPI battery: fix compiler warning"
   https://bugs.launchpad.net/bugs/1247154/+attachment/3897829/+files/0001-UBUNTU-SAUCE-ACPI-battery-fix-compiler-warning.patch

** Also affects: linux (Ubuntu Precise)
   Importance: Undecided
       Status: New

** Changed in: linux (Ubuntu Precise)
     Assignee: (unassigned) => Luis Henriques (henrix)

** Changed in: linux (Ubuntu Precise)
       Status: New => Triaged

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1247154

Title:
  ACPI battery: non-void init function not returning a value

Status in “linux” package in Ubuntu:
  Confirmed
Status in “linux” source package in Precise:
  Triaged

Bug description:
  The drivers/acpi/battery.c init function starts with:

  static int __init acpi_battery_init(void)
  {
  	if (acpi_disabled)
  		return;
  [ ... ]

  This could cause problems because, if ACPI is disabled, the driver
  init function would return 0 (success) without being initialised.

  The following compiler warning is shown when compiling Precise kernel:

  /home/henrix/src/precise/ubuntu-precise/drivers/acpi/battery.c: In function 'acpi_battery_init':
  /home/henrix/src/precise/ubuntu-precise/drivers/acpi/battery.c:1172:3: warning: 'return' with no value, in function returning non-void [-Wreturn-type]

  ProblemType: Bug
  DistroRelease: Ubuntu 12.04
  Package: linux-image-3.2.0-56-generic 3.2.0-56.86
  ProcVersionSignature: Ubuntu 3.2.0-56.86-generic 3.2.51
  Uname: Linux 3.2.0-56-generic x86_64
  AlsaVersion: Advanced Linux Sound Architecture Driver Version 1.0.24.
  ApportVersion: 2.0.1-0ubuntu17.1
  Architecture: amd64
  AudioDevicesInUse:
   USER        PID ACCESS COMMAND
   /dev/snd/controlC2:  ubuntu     1607 F.... pulseaudio
   /dev/snd/controlC1:  ubuntu     1607 F.... pulseaudio
   /dev/snd/controlC0:  ubuntu     1607 F.... pulseaudio
  CRDA: Error: command ['iw', 'reg', 'get'] failed with exit code 1: nl80211 not found.
  Card0.Amixer.info:
   Card hw:0 'Intel'/'HDA Intel at 0xfebf0000 irq 45'
     Mixer name	: 'Generic 1af4 ID 21'
     Components	: 'HDA:1af40021,1af40021,00100101'
     Controls      : 1
     Simple ctrls  : 1
  Card1.Amixer.info:
   Card hw:1 'I82801AAICH'/'Intel 82801AA-ICH with STAC9700,83,84 at irq 11'
     Mixer name	: 'SigmaTel STAC9700,83,84'
     Components	: 'AC97a:83847600'
     Controls      : 8
     Simple ctrls  : 12
  Card2.Amixer.info:
   Card hw:2 'AudioPCI'/'Ensoniq AudioPCI ENS1370 at 0xc400, irq 10'
     Mixer name	: 'Asahi Kasei AK4531'
     Components	: 'AK4531'
     Controls      : 43
     Simple ctrls  : 15
  Date: Fri Nov  1 15:15:26 2013
  HibernationDevice: RESUME=UUID=fb857da5-f276-48a8-a960-9e268be368ca
  InstallationMedia: Ubuntu 12.04.1 LTS "Precise Pangolin" - Release amd64+mac (20120823.1)
  IwConfig:
   lo        no wireless extensions.
   
   eth0      no wireless extensions.
  Lsusb: Error: command ['lsusb'] failed with exit code 1: unable to initialize libusb: -99
  MachineType: Bochs Bochs
  MarkForUpload: True
  ProcEnviron:
   TERM=xterm
   PATH=(custom, no user)
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  ProcFB: 0 EFI VGA
  ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.2.0-56-generic root=UUID=4aa0ea77-9f66-4074-a28f-6f808346c7a6 ro console=ttyS0
  RelatedPackageVersions:
   linux-restricted-modules-3.2.0-56-generic N/A
   linux-backports-modules-3.2.0-56-generic  N/A
   linux-firmware                            1.79.7
  RfKill:
   
  SourcePackage: linux
  StagingDrivers: zram
  UpgradeStatus: No upgrade log present (probably fresh install)
  dmi.bios.date: 01/01/2011
  dmi.bios.vendor: Bochs
  dmi.bios.version: Bochs
  dmi.chassis.type: 1
  dmi.chassis.vendor: Bochs
  dmi.modalias: dmi:bvnBochs:bvrBochs:bd01/01/2011:svnBochs:pnBochs:pvr:cvnBochs:ct1:cvr:
  dmi.product.name: Bochs
  dmi.sys.vendor: Bochs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1247154/+subscriptions