← Back to team overview

kicad-developers team mailing list archive

patch: make "make" fail after errors (makefile.gtk)


This patch prevents "make" from blissfully proceeding after fatal
errors, often hiding them. This patch only changes makefile.gtk,
because I don't know if "make" on any of the other platforms also
supports the -C option.

A question about the netiquette of the kicad-devel list: is it
desirable/tolerated/frowned upon to copy small patches to the
list, so that people can review them ?

- Werner

--- kicad-dev/makefile.gtk.orig	2006-04-09 03:04:57.000000000 -0300
+++ kicad-dev/makefile.gtk	2006-04-09 03:22:39.000000000 -0300
@@ -6,10 +6,11 @@ MAKE_INSTALL = make -f makefile.gtk inst
ERASE = rm -f *.o

-	@for d in $(KICAD_SUBDIRS); do (cd $$d && $(MAKE)); done
+	@for d in $(KICAD_SUBDIRS); do $(MAKE) -C $$d || exit; done

-	@for d in $(KICAD_SUBDIRS_BIN); do (cd $$d && $(MAKE_INSTALL)); done
+	@for d in $(KICAD_SUBDIRS_BIN); do \
+	$(MAKE_INSTALL) -C $$d || exit; done

@for d in $(KICAD_SUBDIRS); do (cd $$d && $(ERASE)); done

/ Werner Almesberger, Buenos Aires, Argentina werner@... /

Follow ups