kicad-developers team mailing list archive

[Dick Hollenbeck <dick@...>]

We ran into this earlier, IIRC it was in PCBNEW. The solution was to 
simply remove this UpdateStatusBar() for all platforms from the 
DrawPanel code. It should not be needed. The status bar should know 
when it needs updating, and this should be done in its OnPaint() 
handling logic.

My point is that when we can find a general solution, which is not 
platform specific, that is preferred over contaminating the code with 
these ifndef WXMACs everywhere. This is what we achieved on status bar 
earlier.

This is like deja vu. Let's find the same solution we did before, and 
then put it into all the executables so we do not have to visit this again.

My suggestion.

Dick

> Those UpdateStatusBar() makes nested Updates in the Statusbar triggering the Event.
>
> --
> Marco
>
> Index: eeschema/eeredraw.cpp
> ===================================================================
> --- eeschema/eeredraw.cpp	(revision 1884)
> +++ eeschema/eeredraw.cpp	(working copy)
> @@ -78,8 +78,9 @@
> {
> DrawPanel->ManageCurseur( DrawPanel, DC, FALSE );
> }
> -
> +#ifndef __WXMAC__ //Quickier refresh and avoid ASSERT under wx-2.9
> UpdateStatusBar();
> +#endif
> GetScreen()->ClrRefreshReq();
>
> // Display the sheet filename, and the sheet path, for non root sheets
>
>
> Index: gerbview/tracepcb.cpp
> ===================================================================
> --- gerbview/tracepcb.cpp	(revision 1884)
> +++ gerbview/tracepcb.cpp	(working copy)
> @@ -84,8 +84,9 @@
>
> Trace_Gerber( DC, GR_COPY, -1 );
> TraceWorkSheet( DC, screen, 0 );
> +#ifndef __WXMAC__ //Quickier refresh and avoid ASSERT under wx-2.9
> UpdateStatusBar();
> -
> +#endif
> if( DrawPanel->ManageCurseur )
> DrawPanel->ManageCurseur( DrawPanel, DC, FALSE );
>
>
>
>
> ------------------------------------
>
> Yahoo! Groups Links