← Back to team overview

kicad-developers team mailing list archive

Re: Metric and English grids sizes.


Dick Hollenbeck wrote:
> Isaac Marino Bavaresco wrote:
>> Wayne Stambaugh escreveu:
>>> I just wanted to get some feedback on the current grid setting design.
>>> Does it make sense to have both the metric and English grid sizes show
>>> up in the grid selection list? Does anyone want to snap to a 0.127mm or
>>> a 0.254mm grid. I propose changing the grid list to only show the
>>> metric grid sizes when millimeters are selected and English grid sizes
>>> when inches are selected. The user grid will always be shown in the
>>> current units. I already have it coded up and working and wanted to
>>> make sure that there were no objections before I made the commit.
>>> Also on a related note, someone changed the last grid setting in pcbnew
>>> from the application settings to a project file setting. Is this really
>>> where we want to save the last setting? It seems to me that this more
>>> of an application setting than a project parameter. If no one objects I
>>> will change it back to an application setting. This implementation also
>>> saves the command ID of the grid instead of the actual grid size.
> Command ID? This is a bug, no?

Only if you add new grid size IDs then it possible that you will get a
warning about an grid size not being available. Grid sizes are looked
up by the command ID that is associated with them. The grid setting
will fall back to the first grid size in the grid list if the command ID
is not found in the list. It's only a bug in my dev branch because I
added some additional metric grid sizes to the pcb grid list. The
current design has the potential to be a bug every time someone decides
to add a new grid size command ID.


>>> It
>>> will break any time someone inserts new commands into the global command
>>> ID file before the grid command IDs. I just found that out the hard
>>> way. If the consensus is to leave the last grid setting in the project
>>> file, this will have to be fixed or it will cause problems in the future.
>>> Wayne
> ------------------------------------
> Yahoo! Groups Links


Follow ups