kicad-developers team mailing list archive

[Dick Hollenbeck <dick@...>]

emmedics4 wrote:
> Dick, 
> Seems that in your last change of dialog_display_options_base.cpp you forgot to commit also the corresponding .fbp file.
> I'm trying to create a panel_display_options_base.fbp coping yours and changing from wxDialog to wxPanel and compiler complaints about the missing of members.
> If you don't have it handly, i could provide myself.
>
> --
> Marco
>
>
>


Hi Marco,


Sorry, I think you may have had to ask about this twice to get my attention.

Back in September I committed a patch that came in from Isaac. Among 
others, he had edited the files:


pcbnew/dialog_display_options_base.h
pcbnew/dialog_display_options_base.cpp


cvpcb/dialog_display_options_base.h
cvpcb/dialog_display_options_base.cpp


by hand, rather than using the respective dialog editors (wxformbuilder 
for pcbnew and *.pjd for cvpcb) to generate these files.

(cvpcb has yet to be converted to wxformbuilder.)

I *missed* the fact that these were hand edits, and not done via proper 
protocol. I apologize, this is really my error, as I had assumed 
responsibility for the commit.

Attached is his patch file, you can see exactly what he did in these 
four files, and I think you can take the current

pcbnew/dialog_display_options_base.fbp

and update it to reproduce the changes he made by hand. I would do this 
for you but I think since you are in there anyway for major work, this 
is well within your capabilities.

There seems to be only one new wxControl added, a via checkbox or something.

The patch is informative only, everything in there is old news.


Thanks,

Dick


 --------------000504080004090602050109 Content-Type: text/x-patch;
name="KiCAD-2009-09-23-R1971-Filled Vias.patch"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
filename="KiCAD-2009-09-23-R1971-Filled Vias.patch"

[Attachment content not displayed.] --------------000504080004090602050109--