kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #04773
Re: CMake requirement...
I had the revision numbers swapped and the diff was backwards. Looks
better with
bzr diff -r2368..2369 CMakeLists.txt
This was a change made by Jean-Pierre. Generally, I would suggest that
anything we can do to make his life easier, even if it means making ours
harder, we should tread softly. Certainly you can learn how to install
CMake from their website if need be. Jean-Pierre's time is valuable
and scarce.
If you truly want to resolve this, then commit a patch like a real
developer. But fix the reason why the change was made in the first place.
Dick
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2010-04-21 12:25:16 +0000
+++ CMakeLists.txt 2010-05-10 18:37:54 +0000
@@ -1,9 +1,10 @@
project(kicad)
+# test the minimum Cmake version requirement (could be different under
unix or Windows
if(WIN32)
- cmake_minimum_required(VERSION 2.6.1 FATAL_ERROR)
+ cmake_minimum_required(VERSION 2.8.0 FATAL_ERROR)
else(WIN32)
- cmake_minimum_required(VERSION 2.6.0 FATAL_ERROR)
+ cmake_minimum_required(VERSION 2.8.0 FATAL_ERROR)
endif(WIN32)
# Path to local CMake modules.
References