kicad-developers team mailing list archive

[Brian Sidebotham <brian.sidebotham@xxxxxxxxx>]

> +
> +void DIALOG_EESCHEMA_OPTIONS::SetFieldName( int aNdx, wxString aName )
> +{
>
>
> I don't recall there being a limit to the number of fields in the
> symbols.  I could be wrong, but that is not what I recall adding support
> for when I added expandable field name lists.  The above function has a
> limit to the number of field names, and maybe this is a limit imposed by
> the dialog UI (probably undesirable if so).

Hi Dick,

Yes that's right this is a limit imposed by the dialog UI. It would be
much better to have an expandable default list in the UI. Whilst I had
my head in the code I forgot that you had added the ability to add
extra custom fields in your field edit dialog, hence I wrongly assumed
DEFAULT_NUMBER_OF_FIELDS (previously NUMBER_OF_FIELDS) was the limit.

> The patch is probably good enough for me to dove tail it into the code
> base, if you don't mind some minor changes.

I don't mind changes to it at all, please do whatever you feel
necessary. I'll observe the changes and learn a bit more!

> I'll get started later this week.  And then do the BOM fix at that time
> also.

Best Regards,

Brian.