← Back to team overview

kicad-developers team mailing list archive

Re: Show in eeschema window title full/short path to open file -- patch

 

On Tue, Jul 20, 2010 at 12:37:29PM -0500, Dick Hollenbeck wrote:
> I DO like the concept of a title which shows the filename up near the
> front, before a long path.
> 
> I think:
> 
> 1) we should be able to agree on a standard format and not go through
> the trouble having this be a configuration option.
Yes, I agree. But I think show full path to opened file is not
best solution.

May be do like vim: filename (path/to/filename-dir) ?
> 
> 2) that your version of wxformbuilder is fairly old.
Hm, I think I download new version :) My version is 3.0.57 --
downloaded several days ago.
> 
> 3) that the patch is showing lines of
> 
> --- pcbnew/dialog_display_options_base.cpp	2010-03-01 11:25:08 +0000
> +++ pcbnew/dialog_display_options_base.cpp	2010-07-13 12:53:39 +0000
> @@ -12,139 +12,139 @@
>  DialogDisplayOptions_base::DialogDisplayOptions_base( wxWindow* parent, wxWindowID id, const wxString& title, const wxPoint& pos, const wxSize& size, long style ) : wxDialog( parent, id, title, pos, size, style )
>  {
>  	this->SetSizeHints( wxDefaultSize, wxDefaultSize );
> -	
> +
>  	wxBoxSizer* bMainSizer;
>  	bMainSizer = new wxBoxSizer( wxHORIZONTAL );
> -	
> +
> 
> 
> What are the -+ lines about?
I think it removed spaces at new lines. I use vim, and configure
it -- when I save file, vim before saving remove all useless
spaces at the end of the strings.

Thanks for feedback.

Regards,
--
    Yury Khalyavin



Follow ups

References