kicad-developers team mailing list archive

[Dick Hollenbeck <dick@xxxxxxxxxxx>]

On 07/21/2010 12:48 AM, Yury Khalyavin wrote:
> On Tue, Jul 20, 2010 at 12:37:29PM -0500, Dick Hollenbeck wrote:
>> I DO like the concept of a title which shows the filename up near the
>> front, before a long path.
>>
>> I think:
>>
>> 1) we should be able to agree on a standard format and not go through
>> the trouble having this be a configuration option.



> Yes, I agree. But I think show full path to opened file is not
> best solution.

Summary:

** I do not like the configuration option.  We need to agree on one solution.  Please
orchestrate this discussion directly with Jean Pierre.

If you can make a proposal that thoroughly understands the notion of the sheet path
(which is not a filename path) and puts things in the order of your importance, you
have a fighting chance of getting a patch like this put in.  But the final patch
should be not more than about 3 changed lines of code.



> 
> May be do like vim: filename (path/to/filename-dir) ?
>>
>> 2) that your version of wxformbuilder is fairly old.
> Hm, I think I download new version :) My version is 3.0.57 --
> downloaded several days ago.


-// C++ code generated with wxFormBuilder (version Dec 21 2009)
+// C++ code generated with wxFormBuilder (version Apr 17 2008)


Then cay you say why your patch is showing Apr 17 2008?

And why your fbp file has removed the field validators, which also suggests that it is
old.  I am concerned about future patches, not this one, which as I said should be
only about 3 lines long.



>>
>> 3) that the patch is showing lines of
>>
>> --- pcbnew/dialog_display_options_base.cpp	2010-03-01 11:25:08 +0000
>> +++ pcbnew/dialog_display_options_base.cpp	2010-07-13 12:53:39 +0000
>> @@ -12,139 +12,139 @@
>>  DialogDisplayOptions_base::DialogDisplayOptions_base( wxWindow* parent, wxWindowID id, const wxString& title, const wxPoint& pos, const wxSize& size, long style ) : wxDialog( parent, id, title, pos, size, style )
>>  {
>>  	this->SetSizeHints( wxDefaultSize, wxDefaultSize );
>> -	
>> +
>>  	wxBoxSizer* bMainSizer;
>>  	bMainSizer = new wxBoxSizer( wxHORIZONTAL );
>> -	
>> +
>>
>>
>> What are the -+ lines about?
> I think it removed spaces at new lines. I use vim, and configure
> it -- when I save file, vim before saving remove all useless
> spaces at the end of the strings.


Well done, I wanted to be sure the problem was in the old source, not the new.  Thanks
for tracking this down.


Dick