← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Saving plot dialog settings


On 01/28/2011 01:18 PM, Marco Mattila wrote:
> On Fri, Jan 28, 2011 at 8:11 PM, Dick Hollenbeck <dick@xxxxxxxxxxx> wrote:
>> Having said that, then are you saying a string like this:
>> AB"CD
>> On the way out, *before* quoting will be a problem?  Will not come back in
>> via DSNLEXER?  Have you verified this problem string with actual testing?
> I'm saying that the comments in OUTPUTFORMATTER::Quoted say that any
> string which has internal quotes will also be wrapped in quotes later
> in this function. If my string (in this case outputDirectory) is AB"CD
> it is going on disk as AB""CD. Based on the comment I think it should
> be "AB""CD". Anyways, if it is on disk as AB""CD it comes back as
> AB""CD. If it is on disk as "AB""CD" it comes back as AB"CD. If that
> is how things are supposed to work, I can strip the extra "'s in

The round trip criteria is not being met, according to you.  So there is a
problem.  You should get back in from DSNLEXER what you send out through

Plain and simple.

I will test, verify and fix. 

I also am switching over to Quoted() in template_fieldnames.cpp, which
probably gave you some wrong direction in the first place.  Won't have time
to go the 2nd step and introduce TEMPLATE_FIELDNAMES_PARSER which I plan to
do later, so that we can continue to be consistent with the same design pattern.

Nice job.