kicad-developers team mailing list archive

[fabrizio <zonkyu@xxxxxxxxx>]

Dear jean-pierre,
in attachment you can find a zipped folder new_kicad_svg.zip that
contains 50 re-drawn .svg icons that are better drawn according to all
the suggestions received.

Additionally, in attachment you can find the file "changes.txt" with a
short list of changes to apply to the last version of kicad so that
all icons are used.

Forgive me for not having used a classic patch file but I think this
way is easier.

This patch with the previous one (already submitted) should make the
420 new icons quite usable.

Would it be possible to know how long it will take until this new
icons will make it to the stable distribution of kiCad?

Best regards
Fabrizio


On Mon, Sep 12, 2011 at 7:37 PM, fabrizio <zonkyu@xxxxxxxxx> wrote:
> jean-pierre,
> no worries, I'll create all the icons you mentioned tomorrow and
> submit a new patch. Mean time would it be possible for you to submit
> the previous patch while you take care of the double icon_kicad.svg
> deal?
>
> Regards
> Fabrizio
>
>
> On Mon, Sep 12, 2011 at 6:44 PM, jean-pierre charras
> <jp.charras@xxxxxxxxxx> wrote:
>> Le 12/09/2011 18:02, fabrizio a écrit :
>>>
>>> Hello,
>>> the following patch does the following:
>>> - fix spacing between app icons in kicad right bar
>>> - several .svg icons were update (better look and coherence)
>>> - hotkey list window now has the right colour and better size (it
>>> would be good to automatically resize this window with its content but
>>> I do not know how to do it)
>>> - fix kicad left menu spacing and icon size (now 26pt)
>>>
>>> Not 100 % sure if this will create a problem for other OSs but I would
>>> propose to consider deleting the following folders:
>>> - artwork
>>> - bitmaps_xpm
>>>
>>> and maybe:
>>> - resources
>>>
>>> Regards
>>> Fabrizio
>>> PS all icons need to be rebuilt (sorry for this but when I start
>>> modifying .svg files it is not easy, for me, to be smarter than CMake)
>>>
>>
>> Some thoughts:
>>
>> 2 kicad icons ( icon_kicad.svg and icon_kicad2.svg ) are confusing.
>> One is enough.
>> Remove icon_kicad.svg and keep new icon_kicad2.svg is better
>> Do not forget to rename icon_kicad2.svg to icon_kicad.svg.
>> icon_kicad2.svg is better because it is more readable in 16x16 or 32x32
>> pixels formats,
>> i.e. when this icon appears in menus or task bar.
>>
>> artwork is now not needed, but I am thinking it is used by MacOSX folks.
>> So I ask for them to remove this folder and use new .svg icons.
>>
>> bitmaps_xpm contains "old" icons.
>>
>> Before removing it, the Kicad doc must be updated, and it is a lot of work.
>> (otherwise it is not understandable if we use new icons in a stable release,
>> and the current doc, at least for new users)
>> An it will be updated only when new icons are stable.
>>
>> In Eeschema, the icon used for annotation tool is not self explanatory.
>> Can you create a better icon ( like the netlist icon for instance) ?
>> The icon used to add an image in Eeschema is not good (I am not clever to do
>> icons).
>> Can you create a better icon ?
>>
>> Thanks.
>>
>> --
>> Jean-Pierre CHARRAS
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>

### change line 264 of pcbnew/tool_pcb.cpp

m_HToolBar->AddTool( ID_AUX_TOOLBAR_PCB_SELECT_LAYER_PAIR, wxEmptyString,
                     KiBitmap( select_layer_pair_xpm ), SEL_LAYER_HELP );
                         
### change line 126 of eeschema/tool_pcb.cpp
                      
m_HToolBar->AddTool( ID_GET_TOOLS, wxEmptyString, KiBitmap( bom_xpm ),
                         _( "Generate bill of materials and/or cross references" ) );
                         
### add line 131 of bitmaps_png/CMakeLists.txt
bom

### add line 111 of includes/bitmaps.h
EXTERN_BITMAP( bom_xpm )


### change line 535 of bitmaps_png/CMakeLists.txt

COMMAND ${Inkscape_EXECUTABLE} --export-area-snap -f ${inputFile} -e ${outFile} -w ${pngWidth} -h ${pngHeight} > ${TMP_DIR}/${bmn}.inkscape.log

### delete file: bitmaps_png/background_metal.svg and clean up bitmaps_png/CMakeLists.txt accordingly

Attachment: new_kicad_svg.zip
Description: Zip archive