← Back to team overview

kicad-developers team mailing list archive

Re: You missed a file in the zlib CMake script...


On 05/04/2012 11:38 AM, jean-pierre charras wrote:
> Le 04/05/2012 16:29, Wayne Stambaugh a écrit :
>> On 5/4/2012 5:48 AM, Lorenzo Marcantonio wrote:
>>> By the way, was it really necessary to embed the whole zlib? It should be already provided with wx... (or is the wx one
>>> statically linked?)
>>> === modified file 'zlib/CMakeLists.txt'
>>> --- zlib/CMakeLists.txt 2012-05-03 18:37:56 +0000
>>> +++ zlib/CMakeLists.txt 2012-05-04 09:47:20 +0000
>>> @@ -1,4 +1,5 @@
>>> set(ZLIB_SRCS
>>> + adler32.c
>>> compress.c
>>> crc32.c
>>> deflate.c
>> It's not necessary since zlib is provided by wxWidgets on Windows when libz cannot be found when configure is run. FindZLIB.cmake
>> was removed when we stopped including minizip with the project. I see no advantage to including the zlib source files in the
>> project. Use FindZLIB and set the cmake include(ZLIB_INCLUDE) and add ZLIB_LIBRARIES to the list of libraries to build the
>> executables that require zlib.
> In fact, this is the zlib tree coming from wxWidgets, so include zlib in Kicad should not be necessary.
> However, zlib library is easy to find, but zlib headers are not in wxWidgets standard include path,
> and unless I missed something we cannot easily use them because they are only in wxWidgets/src/zlib path.
> But if common_plotPDF_functions.cpp can use wxZipOutputStream, it fixes this problem.

A combo of




should do the trick.

Although I did not verify availability in 2.8


Follow ups