← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Reworking patchlets, first issue


On Fri, May 11, 2012 at 09:20:50AM +0200, Miguel Angel Ajo Pelayo wrote:
> Yes, I had the feeling that it was a lot of work, if it causes you trouble
> may be it's just better to identifty all the affected parts and write a test
> procedure that we all could replay "as robots", but robots that
> for sure will add their own style since we're all humans (luckily :D )

I did banking code in COBOL for the 2K issue... there not much worse
than realigning structs by column number in a sort control card XD (I
personally 'killed' 120000 customers during preproduction deployment
since they didn't match and were marked inactive:P)

Anyway I'm used to code reviews, they asks for them a lot (for safety
software which has to be compliant and so on). At least they didn't ask
(YET) for formal proof of correctness :P

The advantage in doing these small patches is that's relatively easy
(like bzr bisect IIRC) to pinpoint where shit happened...

Lorenzo Marcantonio
Logos Srl

Follow ups