← Back to team overview

kicad-developers team mailing list archive

Rev 3597: Add zone duplication to pcbnew.



Your commit about zone duplication has *very* serious issues and currently breaks Pcbnew:
- No test is made, so a zone can be added to the same layer (duplicate zone on same layers)
- No DRC performed on the new added zone on a copper layer (currently it breaks the board).
- The new zone is not merged with existing zones (if any)
- The duplicate zone command cannot be undone.
- The filled areas are duplicated, that is bad (filled areas are certainly bad)

see PCB_EDIT_FRAME::End_Zone( wxDC* DC ) for instance to do DRC, merging and others.

Jean-Pierre CHARRAS

Follow ups