← Back to team overview

kicad-developers team mailing list archive

Re: Question about PCB_PARSER


On Mon, Aug 06, 2012 at 10:30:48AM -0400, Wayne Stambaugh wrote:
> Good catch.  The base DSNLEXER constructor that I called does not
> take ownership of the LINEREADER.  The other two DSNLEXER
> constructors take ownership of the LINEREADER by default.  I must
> have misread it when I looked at.  I will fix it as soon as I get a
> chance.

I think that simply passing a LINEREADER built on the stack would work... also we need to be careful with dynamic allocation since there are exception runnings in that section of code (and these need to be catched to delete the dynamic objects).

Lorenzo Marcantonio
Logos Srl

Follow ups