← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Append schematic: copy the contents of one schematic file into another


El 22/01/13 09:47, jp charras escribió:
> Le 21/01/2013 10:46, Jacobo Aragunde Pérez a écrit :
>> ...
>> I've checked the approach used in Pcbnew. After an import, the current
>> document name changes, so it doesn't overwrite the existing one unless
>> you specifically want to.
>> I think I will mimic this behaviour for two reasons: coherence inside
>> the application and protection against what you mention above.
> I am thinking  "the current document name changes" means the imported
> sheet, of one of the imported sub sheet file name:
> But a schematic is not a board.
> A board is only one file, a schematic project is a set of files.
> ...

After your comments, I don't think a name change would work in this case
any more. I'll keep the same document name. I've added a warning to ask
the user to save the document before the append operation, so they can
always revert the changes.

About loops, I don't think it makes sense fixing it only for this
feature, it needs a solution that works for all the application. I guess
that the warning plus the save operation would be enough for now.

> Therefore (like in paste block) time stamps of new items should be
> checked and updated (and perhaps the references).
> I am thinking a lot of users will use such a feature to create multiple
> instances of a basic sheet, as an alternative to paste block,
> so be careful about multiple imports of the same sheet.

If you consider this is important, I'll check how timestamps work in the
paste block operation. I guess that the goal is resetting the timestamps
for the imported components, isn't it?

> Also have a look to the code relative to a sheet filename change, for
> simples and complex hierarchies (and the conversion between these
> hierarchies)

I'll also fix this problem using the full file path when there's a problem.

Jacobo Aragunde
Software Engineer at Igalia

Follow ups