kicad-developers team mailing list archive

[Anton Blanchard <anton@xxxxxxxxx>]

When moving most symbols in the component editor we refresh the screen
(OnLeftClick -> EndDrawGraphicItem). Pins are a special case and call
into PlacePin which doesn't trigger a refresh.

As a result of this, we end up with corruption whenever we move a pin.
This patch removes the redraw of the pin being moved and triggers a
refresh, similar to other symbols.
 
Index: b/eeschema/pinedit.cpp
===================================================================
--- a/eeschema/pinedit.cpp
+++ b/eeschema/pinedit.cpp
@@ -268,12 +268,7 @@ another pin. Continue?" ) );
         Pin->ClearFlags();
     }
 
-    m_canvas->CrossHairOff( DC );
-    bool showPinText = true;
-    CurrentPin->Draw( m_canvas, DC, wxPoint( 0, 0 ), UNSPECIFIED_COLOR, GR_DEFAULT_DRAWMODE,
-                      &showPinText, DefaultTransform );
-    m_canvas->CrossHairOn( DC );
-
+    m_canvas->Refresh();
     m_drawItem = NULL;
 }