kicad-developers team mailing list archive

[Miguel Angel Ajo Pelayo <miguelangel@xxxxxxx>]

Pushed to revision 3996,   Brian, can you re-test Dick's class-lock now with those fixes in place?

-------
PS:


There is something broken yet with datatypes flying to python when you change parameters for a wizard

[Pads][*steps]<= 3.0
[Pads][length]<= 50000000,000000
[Pads][clearance]<= 1000000,000000
[Pads][width]<= 10000000,000000
calling GetModule()
Exception: invalid literal for float(): 50000000,000000
         : <traceback object at 0x10faac440>
m_FootprintWizard->GetModule() returns NULL


looks like something related to locale conversion, that's been there broken for a while, I will work on fixing it back tomorrow, almost 2am here ':D




Miguel Angel Ajo
http://www.nbee.es
+34911407752
skype: ajoajoajo

On 12/03/2013, at 01:44, Miguel Angel Ajo Pelayo <miguelangel@xxxxxxx> wrote:

> Don't worry Wayne, I will commit it in a few seconds, I'm trying, but my bzr just not logged in in a new dev machine I'm using :)
> 
> I sometimes yet need to look at my notes to re-discover what did each python related define… 
> 
> 
> Miguel Angel Ajo
> http://www.nbee.es
> +34911407752
> skype: ajoajoajo
> 
> On 12/03/2013, at 01:37, Wayne Stambaugh <stambaughw@xxxxxxxxxxx> wrote:
> 
>> On 3/11/2013 7:48 PM, Miguel Angel Ajo Pelayo wrote:
>>> Hmm, I recompiled several times (without the WXPYTHON option) , not
>>> getting the footprint wizard, and then I realized that somebody changed
>>> this ifdef:
>>> 
>>> #ifdef KICAD_SCRIPTING_WXPYTHON
>>>    m_mainToolBar->AddTool( ID_MODEDIT_NEW_MODULE_FROM_WIZARD,
>>> wxEmptyString,
>>>                            KiBitmap( module_wizard_xpm ),
>>>                            _( "New module from footprint wizard" ) );
>>> #endif
>>> 
>>> 
>>> in tool_modedit.cpp
>>> 
>>> it only needs to be KICAD_SCRIPTING, there is no WXPYTHON dependency in
>>> the footprint wizard :-),
>> 
>> Sorry about that.  I didn't realize that wxPython was not in play here.  I incorrectly assumed since it was dealing with UI elements (the toolbar) that wxPython was in play.  I'll fix it to look for KICAD_SCRIPTING.
>> 
>> Wayne
>> 
>>> when I made that I wanted to be scripting language agnostic, we can even
>>> write C++ wizards with current
>>> implementation just subclassing the FootprintWizard class
>>> (class_footprint_wizard.h/cpp) :)
>>> 
>>> I'm going to change it, and make the test :-)
>>> 
>>> 
>>> Miguel Angel Ajo
>>> http://www.nbee.es
>>> +34911407752
>>> skype: ajoajoajo
>>> 
>>> On 11/03/2013, at 15:30, Miguel Angel Ajo Pelayo <miguelangel@xxxxxxx
>>> <mailto:miguelangel@xxxxxxx>> wrote:
>>> 
>>>> Ok, more than 5 minutes, removing WXPYTHON scripting needs a full
>>>> pcbnew rebuild, probably around 15 min… :)
>>>> 
>>>> Miguel Angel Ajo
>>>> http://www.nbee.es <http://www.nbee.es/>
>>>> +34911407752
>>>> skype: ajoajoajo
>>>> 
>>>> On 11/03/2013, at 15:26, Miguel Angel Ajo Pelayo <miguelangel@xxxxxxx
>>>> <mailto:miguelangel@xxxxxxx>> wrote:
>>>> 
>>>>> I'm going to test it right now, give me 5 minutes :)
>>>>> 
>>>>> Miguel Angel Ajo
>>>>> http://www.nbee.es <http://www.nbee.es/>
>>>>> +34911407752
>>>>> skype: ajoajoajo
>>>>> 
>>>>> On 11/03/2013, at 15:25, Dick Hollenbeck <dick@xxxxxxxxxxx
>>>>> <mailto:dick@xxxxxxxxxxx>> wrote:
>>>>> 
>>>>>> class PyLOCK
>>>>>> {
>>>>>>  PyGILState gil_state;
>>>>>> 
>>>>>> public:
>>>>>>  PyLOCK()      { gil_state = PyGILState_Ensure(); }
>>>>>>  ~PyLOCK()     { PyGILState_Release( gil_state ); }
>>>>>> };
>>>>> 
>>>> 
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>> 
>> 
>> 
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>