← Back to team overview

kicad-developers team mailing list archive

Re: Kicad Coding style checker

 

Thanks for the feedback Carl,  I'll add it, it's a good idea, even
launching "less" if the result is big could also be useful.


2013/3/17 Carl Poirier <carl.poirier.2@xxxxxxxxx>

> Hi Miguel,
>
> I tried your checkcoding tool and it works great. The only comment I can
> give you is I would add some blank lines between each file suggestions
> output so they are easier to find.
>
> Carl
>
> On Fri, Mar 15, 2013 at 7:25 PM, Miguel Angel Ajo Pelayo <
> miguelangel@xxxxxxx> wrote:
>
>>
>>    I wrote it for myself, but as I think it can be interesting for
>> everybody I added it to the tools directory,
>> it's a tool that checks with 'bzr status' for modified files, and it
>> dumps a suggestions from uncrustify,
>> if you like them you can just say "y" , "e" launches an $EDITOR for the
>> file, "n" or enter ignores.
>>
>> kicad ajo$* ./tools/checkcoding.py *
>> Suggestions for: pcbnew/scripting/pcbnew_footprint_wizards.cpp
>> --- pcbnew/scripting/pcbnew_footprint_wizards.cpp
>> +++ pcbnew/scripting/pcbnew_footprint_wizards.cpp.uncrustified
>> @@ -106,7 +106,7 @@
>>
>>      PyObject*   result = CallMethod( aMethod, aArglist );
>>
>> -    if(result )
>> +    if( result )
>>      {
>>      }
>>
>> Shall I clean pcbnew/scripting/pcbnew_footprint_wizards.cpp ? (y/N/E) y
>> pcbnew/scripting/pcbnew_footprint_wizards.cpp UPDATED
>>
>> kicad ajo$
>>
>> At this moment, it will only work when called from the base project
>> directory
>>
>> Miguel Angel Ajo
>> http://www.nbee.es
>> +34911407752
>> skype: ajoajoajo
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>


-- 

Miguel Angel Ajo Pelayo
http://www.nbee.es
+34 636 52 25 69
skype: ajoajoajo

References