kicad-developers team mailing list archive

[Carl Poirier <carl.poirier.2@xxxxxxxxx>]

By the way, uncrustify was telling me about unknown symbols which I believe
may be some mistake on my side, so I just commented out the lines in the
aformentioned tool to get it to work. I forgot to remove them before
creating the patch though so just ignore this change or look at this one
instead!

Carl

On Sun, Mar 17, 2013 at 1:04 PM, Carl Poirier <carl.poirier.2@xxxxxxxxx>wrote:

> I found a few other kinks in the coding style of the patch using the
> checkcoding.py tool from Miguel and made sure it still compiles fine using
> the latest revision.
>
> Please let me know if everything is alright.
>
> Carl
>
>
> On Thu, Mar 14, 2013 at 11:25 AM, Carl Poirier <carl.poirier.2@xxxxxxxxx>wrote:
>
>> Hi Dick,
>>
>> I just wanted to have a follow-up on that patch. Is everything alright?
>>
>> Thanks,
>>
>> Carl
>>
>>
>> On Thu, Mar 7, 2013 at 2:40 PM, Carl Poirier <carl.poirier.2@xxxxxxxxx>wrote:
>>
>>> Hi Dick,
>>>
>>> Thanks for pointing that out. This one should hopefully do the trick.
>>>
>>> Carl
>>>
>>>
>>> On Thu, Mar 7, 2013 at 1:35 PM, Dick Hollenbeck <dick@xxxxxxxxxxx>wrote:
>>>
>>>> On 03/07/2013 10:39 AM, Carl Poirier wrote:
>>>> > +    for(unsigned i = 0; i < itemList.size(); i++)
>>>>
>>>>
>>>> for( unsigned i = 0; i < itemList.size(); i++ )
>>>>
>>>>
>>>> in 4 or more places.
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>>
>>
>

Attachment: cmp_and_mod_display_library_8.patch
Description: Binary data