← Back to team overview

kicad-developers team mailing list archive

Re: m_colorsSettings in BOARD


On 04/12/2013 12:17 AM, Lorenzo Marcantonio wrote:
> On Thu, Apr 11, 2013 at 04:17:15PM -0400, Wayne Stambaugh wrote:
>> This isn't a bad thing unless the pointer to g_colorSettings changes.
>> It hides the fact the color settings in Pcbnew are a global variable (it
>> seems to me that they should be a member of PCB_EDIT_FRAME or one of the
>> classes it is derived from) and prevents the g_colorSettings variable
>> from littering the all the objects derived from BOARD_ITEM which I
>> believe use to be the case.  The color settings could reside and be
> Thanks exactly what I was asking for. It wasn't clear if colours were
> intended to be members or globals. 

Members.  BOARD::{Get,Set}ColorSettings is the interface, and is there to facilitate a
future movement of the actual storage.

See my other posting a few minutes ago.